-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate locking of commits during release #4561
Comments
[Triage] Adding @bbarani @peterzhuamazon @rishabh6788 |
GH workflow sounds good to me. Can be manually triggered with inputs. Lease resistance path I believe. Is it possible to use the same workflow to update those commits as we want. For example: Scenario 1:Input: Now RC1 is built but looks like common-utils and other bunch of repos have changed commits. Scenario 2:Input: Scenrio 3:Input: Is it possible to do that or you think that can come as an enhancement? |
@gaiksaya once we have the RC number for a release, everything falls under |
Not really right? In order to generate RC2, we would first update the commit in manifest and then trigger RC to include that commit. So after first RC, the process is opposite. |
Closing this as the manifest lock automation enhancement is completed. |
Is your feature request related to a problem? Please describe
We lock commits in the manifest files after release candidate are generated in order to avoid unintentional commits from sneaking in. Example: #4560
Describe the solution you'd like
Automate this process instead of manually copy/paste and then create a PR. Since we have disabled ci check of the manifests there are high chances of human copy/paste error.
Describe alternatives you've considered
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: