Skip to content

Commit 0a17bc2

Browse files
Add current user to adm group to access logs (#4553)
Signed-off-by: Peter Zhu <[email protected]>
1 parent d54b205 commit 0a17bc2

File tree

8 files changed

+16
-8
lines changed

8 files changed

+16
-8
lines changed

docker/ci/dockerfiles/current/test.almalinux8.systemd-base.x64.arm64.ppc64le.dockerfile

+1
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,7 @@ RUN dnf install -y sudo && \
110110
useradd -u 1002 -g 1002 opensearch-dashboards && \
111111
usermod -a -G opensearch $CONTAINER_USER && \
112112
usermod -a -G opensearch-dashboards $CONTAINER_USER && \
113+
usermod -a -G adm $CONTAINER_USER && \
113114
id && \
114115
echo "$CONTAINER_USER ALL=(root) NOPASSWD:`which systemctl`, `which env`, `which usermod`, `which dnf`, `which yum`, `which rpm`, `which chmod`, `which kill`, `which curl`, /usr/share/opensearch-dashboards/bin/opensearch-dashboards-plugin" >> /etc/sudoers.d/$CONTAINER_USER
115116

docker/ci/dockerfiles/current/test.ubuntu2004.systemd-base.x64.arm64.ppc64le.dockerfile

+1
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,7 @@ RUN apt-get install -y sudo && \
128128
useradd -u 1002 -g 1002 -s /bin/bash -d /home/opensearch-dashboards -m opensearch-dashboards && \
129129
usermod -a -G opensearch $CONTAINER_USER && \
130130
usermod -a -G opensearch-dashboards $CONTAINER_USER && \
131+
usermod -a -G adm $CONTAINER_USER && \
131132
id && \
132133
echo "$CONTAINER_USER ALL=(root) NOPASSWD:`which systemctl`, `which env`, `which usermod`, `which apt`, `which apt-get`, `which apt-key`, `which dpkg`, `which chmod`, `which kill`, `which curl`, `which tee`, /usr/share/opensearch-dashboards/bin/opensearch-dashboards-plugin" >> /etc/sudoers.d/$CONTAINER_USER
133134

docker/ci/dockerfiles/legacy/test.rockylinux8.systemd-base.x64.arm64.dockerfile

+1-1
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ RUN dnf install -y sudo && \
109109
groupadd -g 1002 opensearch-dashboards && \
110110
useradd -u 1002 -g 1002 opensearch-dashboards && \
111111
usermod -a -G opensearch $CONTAINER_USER && \
112-
usermod -a -G opensearch-dashboards $CONTAINER_USER && \
112+
usermod -a -G adm $CONTAINER_USER && \
113113
id && \
114114
echo "$CONTAINER_USER ALL=(root) NOPASSWD:`which systemctl`, `which env`, `which usermod`, `which dnf`, `which yum`, `which rpm`, `which chmod`, `which kill`, `which curl`, /usr/share/opensearch-dashboards/bin/opensearch-dashboards-plugin" >> /etc/sudoers.d/$CONTAINER_USER
115115

jenkins/opensearch-dashboards/integ-test.jenkinsfile

+3-3
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@ def docker_images = [
2121
]
2222

2323
def docker_args = [
24-
"tar": "-u 1000 -e BROWSER_PATH=electron",
25-
"rpm": "--entrypoint=/usr/lib/systemd/systemd -u root --privileged -v /sys/fs/cgroup:/sys/fs/cgroup:rw --cgroupns=host -e BROWSER_PATH=electron",
26-
"deb": "--entrypoint=/usr/lib/systemd/systemd -u root --privileged -v /sys/fs/cgroup:/sys/fs/cgroup:rw --cgroupns=host -e BROWSER_PATH=electron",
24+
"tar": "-u 1000",
25+
"rpm": "--entrypoint=/usr/lib/systemd/systemd -u root --privileged -v /sys/fs/cgroup:/sys/fs/cgroup:rw --cgroupns=host",
26+
"deb": "--entrypoint=/usr/lib/systemd/systemd -u root --privileged -v /sys/fs/cgroup:/sys/fs/cgroup:rw --cgroupns=host",
2727
"zip": "-u ContainerAdministrator",
2828
]
2929

src/test_workflow/integ_test/distribution_deb.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,9 @@ def install(self, bundle_name: str) -> None:
5050
'&&',
5151
f'sudo chmod 0755 {os.path.dirname(self.config_path)} {self.log_dir}',
5252
'&&',
53-
f'sudo usermod -a -G {self.filename} `whoami`'
53+
f'sudo usermod -a -G {self.filename} `whoami`',
54+
'&&',
55+
'sudo usermod -a -G adm `whoami`'
5456
]
5557
)
5658
subprocess.check_call(deb_install_cmd, cwd=self.work_dir, shell=True)

src/test_workflow/integ_test/distribution_rpm.py

+3-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,9 @@ def install(self, bundle_name: str) -> None:
5252
'&&',
5353
f'sudo chmod 0755 {os.path.dirname(self.config_path)} {self.log_dir}',
5454
'&&',
55-
f'sudo usermod -a -G {self.filename} `whoami`'
55+
f'sudo usermod -a -G {self.filename} `whoami`',
56+
'&&',
57+
'sudo usermod -a -G adm `whoami`'
5658
]
5759
)
5860
subprocess.check_call(rpm_install_cmd, cwd=self.work_dir, shell=True)

tests/tests_test_workflow/test_integ_workflow/integ_test/test_distribution_deb.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,8 @@ def test_install(self, check_call_mock: Mock) -> None:
4949
"dpkg --install opensearch.deb && "
5050
f"sudo chmod 0666 {self.distribution_deb.config_path} && "
5151
f"sudo chmod 0755 {os.path.dirname(self.distribution_deb.config_path)} {self.distribution_deb.log_dir} && "
52-
f"sudo usermod -a -G opensearch `whoami`"
52+
f"sudo usermod -a -G opensearch `whoami` && "
53+
f"sudo usermod -a -G adm `whoami`"
5354
),
5455
args_list[0][0][0],
5556
)

tests/tests_test_workflow/test_integ_workflow/integ_test/test_distribution_rpm.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,8 @@ def test_install(self, check_call_mock: Mock) -> None:
4949
"yum install -y opensearch.rpm && "
5050
f"sudo chmod 0666 {self.distribution_rpm.config_path} && "
5151
f"sudo chmod 0755 {os.path.dirname(self.distribution_rpm.config_path)} {self.distribution_rpm.log_dir} && "
52-
f"sudo usermod -a -G opensearch `whoami`"
52+
f"sudo usermod -a -G opensearch `whoami` && "
53+
f"sudo usermod -a -G adm `whoami`"
5354
),
5455
args_list[0][0][0],
5556
)

0 commit comments

Comments
 (0)