Remove labels arg for closing GH issue #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sayali Gaikawad <[email protected]>
gaiksaya
requested review from
peterzhuamazon,
prudhvigodithi,
rishabh6788,
Divyaasm and
zelinh
as code owners
|
Will remove the label requirement cause some issues with same name to be mistakenly closed? |
No the label arg is complete ignore in the library. https://github.com/opensearch-project/opensearch-build-libraries/blob/main/vars/closeGithubIssue.groovy#L22-L28 |
Signed-off-by: Sayali Gaikawad <[email protected]>
Done! It was 7.0.1 which was unreleased but this qualifies for minor bump as well. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #531 +/- ##
=========================================
Coverage 84.72% 84.72%
Complexity 105 105
=========================================
Files 115 115
Lines 648 648
Branches 71 71
=========================================
Hits 549 549
Misses 29 29
Partials 70 70 ☔ View full report in Codecov by Sentry. |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 11, 2024
Signed-off-by: Sayali Gaikawad <[email protected]> (cherry picked from commit 4e94ed7) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See the library here https://github.com/opensearch-project/opensearch-build-libraries/blob/main/vars/closeGithubIssue.groovy
Labels are not required in the code execution. Removing non required args
Issues Resolved
closes #529
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.