Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the component_build_result field for Not Available scenario. #465

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

prudhvigodithi
Copy link
Member

Description

In the following scenario treat the Not Available as failure, this PR will update the component_build_result to failed when the status is Not Available.

components:
  - name: OpenSearch-Dashboards
    command: ./test.sh integ-test manifests/2.16.0/opensearch-dashboards-2.16.0-test.yml
      --paths opensearch=https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/2.16.0/10128/linux/arm64/rpm
      opensearch-dashboards=https://ci.opensearch.org/ci/dbc/distribution-build-opensearch-dashboards/2.16.0/7849/linux/arm64/rpm
      --component OpenSearch-Dashboards
    configs:
      - name: with-security
        status: Not Available
        yml: URL not available
        cluster_stdout:
          - https://ci.opensearch.org/ci/dbc/integ-test-opensearch-dashboards/2.16.0/7849/linux/arm64/rpm/test-results/6123/integ-test/OpenSearch-Dashboards/with-security/local-cluster-logs/id-0/stdout.txt
          - https://ci.opensearch.org/ci/dbc/integ-test-opensearch-dashboards/2.16.0/7849/linux/arm64/rpm/test-results/6123/integ-test/OpenSearch-Dashboards/with-security/local-cluster-logs/id-1/stdout.txt
        cluster_stderr:
          - https://ci.opensearch.org/ci/dbc/integ-test-opensearch-dashboards/2.16.0/7849/linux/arm64/rpm/test-results/6123/integ-test/OpenSearch-Dashboards/with-security/local-cluster-logs/id-0/stderr.txt
          - https://ci.opensearch.org/ci/dbc/integ-test-opensearch-dashboards/2.16.0/7849/linux/arm64/rpm/test-results/6123/integ-test/OpenSearch-Dashboards/with-security/local-cluster-logs/id-1/stderr.txt
      - name: without-security
        status: Not Available
        yml: URL not available
        cluster_stdout:
          - https://ci.opensearch.org/ci/dbc/integ-test-opensearch-dashboards/2.16.0/7849/linux/arm64/rpm/test-results/6123/integ-test/OpenSearch-Dashboards/without-security/local-cluster-logs/id-2/stdout.txt
          - https://ci.opensearch.org/ci/dbc/integ-test-opensearch-dashboards/2.16.0/7849/linux/arm64/rpm/test-results/6123/integ-test/OpenSearch-Dashboards/without-security/local-cluster-logs/id-3/stdout.txt
        cluster_stderr:
          - https://ci.opensearch.org/ci/dbc/integ-test-opensearch-dashboards/2.16.0/7849/linux/arm64/rpm/test-results/6123/integ-test/OpenSearch-Dashboards/without-security/local-cluster-logs/id-2/stderr.txt
          - https://ci.opensearch.org/ci/dbc/integ-test-opensearch-dashboards/2.16.0/7849/linux/arm64/rpm/test-results/6123/integ-test/OpenSearch-Dashboards/without-security/local-cluster-logs/id-3/stderr.txt

Issues Resolved

Part of opensearch-project/opensearch-metrics#56 and opensearch-project/opensearch-metrics#51

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.26%. Comparing base (0b44ea2) to head (3e2025d).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #465   +/-   ##
=========================================
  Coverage     84.26%   84.26%           
  Complexity       80       80           
=========================================
  Files           106      106           
  Lines           521      521           
  Branches         61       61           
=========================================
  Hits            439      439           
  Misses           26       26           
  Partials         56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterzhuamazon
Copy link
Member

Please update version.

@prudhvigodithi
Copy link
Member Author

Please update version.

Just done, thanks.

@prudhvigodithi prudhvigodithi merged commit 3822ade into opensearch-project:main Jul 30, 2024
9 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 30, 2024
…o. (#465)

Signed-off-by: Prudhvi Godithi <[email protected]>
(cherry picked from commit 3822ade)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants