Skip to content

Conversation

@derek-ho
Copy link
Collaborator

@derek-ho derek-ho commented Nov 8, 2022

Signed-off-by: Derek Ho [email protected]

Description

Keeps track of interval selected in the explorer and timechart header so that the interval is not reset whenever the query changes

Issues Resolved

#1249

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@derek-ho derek-ho marked this pull request as ready for review November 8, 2022 16:13
@derek-ho derek-ho requested a review from a team as a code owner November 8, 2022 16:13
Signed-off-by: Derek Ho <[email protected]>
} else {
findAutoInterval(startTime, endTime);
if (!selectedIntervalRef.current || selectedIntervalRef.current.text === 'Auto') {
findAutoInterval(startingTime, endingTime);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the difference between startingTime and startTime?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may need someone more familiar with this component/code (@mengweieric ?) - but from what I can tell this explorer is rendered by both Application analytics and event analytics - for event analytics startTime is undefined, resulting in auto interval not getting picked up. In either case startingTime should be already set above based on the query so I think(?) this is a more general implementation

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes confirmed. Event analytics previously does not use any passed in start/starting time, I think later there's live tail introduced with starting/ending time for differentiating existing start/end time just for reusing the exiting data fetching

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2022

Codecov Report

Attention: Patch coverage is 50.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 41.70%. Comparing base (a1527c5) to head (4cae301).
Report is 4 commits behind head on 2.4.

Files with missing lines Patch % Lines
...ics/explorer/timechart_header/timechart_header.tsx 50.00% 1 Missing ⚠️
...alytics/components/dashboard/dashboard_content.tsx 0.00% 1 Missing ⚠️
...ace_analytics/requests/services_request_handler.ts 0.00% 1 Missing ⚠️

❌ Your project status has failed because the head coverage (41.70%) is below the target coverage (70.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@              Coverage Diff              @@
##                2.4    #1266       +/-   ##
=============================================
- Coverage     70.27%   41.70%   -28.57%     
  Complexity      292      292               
=============================================
  Files            42      296      +254     
  Lines          2395    17747    +15352     
  Branches        248     4277     +4029     
=============================================
+ Hits           1683     7401     +5718     
- Misses          571    10174     +9603     
- Partials        141      172       +31     
Flag Coverage Δ
dashboards-observability 37.24% <50.00%> (?)
opensearch-observability 70.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

joshuali925
joshuali925 previously approved these changes Nov 8, 2022
mengweieric
mengweieric previously approved these changes Nov 8, 2022
@derek-ho derek-ho changed the base branch from 2.x to 2.4 November 8, 2022 21:30
@derek-ho derek-ho dismissed stale reviews from mengweieric and joshuali925 November 8, 2022 21:30

The base branch was changed.

@joshuali925
Copy link
Member

CI failed, retrying. not sure why recently bootstrap often fails

@mengweieric mengweieric self-requested a review November 9, 2022 17:17
@derek-ho derek-ho merged commit 82d634c into opensearch-project:2.4 Nov 9, 2022
@derek-ho derek-ho deleted the fix-plot-autointerval branch November 9, 2022 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants