Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,21 @@ class HybridQueryScoreDocsMerger<T extends ScoreDoc> {
* @return merged array of ScoreDocs objects
*/
public T[] merge(final T[] sourceScoreDocs, final T[] newScoreDocs, final Comparator<T> comparator, final boolean isSortEnabled) {
// The length of sourceScoreDocs or newScoreDocs can be 0 in the following conditions
// 1. When concurrent segment search is enabled then there can be multiple collector instances that can have search results.
// 2. The total hits count of every collector instance represent the actual count of search results present in the shard
// irrespective of pagination.
// 3. If the PagingFieldCollector removes the search results as per `search_after` criteria and totalHits added in the collector is
// greater than 0,
// then the newTopFieldDocs method in the HybridCollectorManager will set the fieldDocs as TopFieldDocs(totalHits, new FieldDoc[0],
// sortFields).
// In this case the size of fieldDocs is 0 with no delimiters.
if (sourceScoreDocs.length == 0) {
return newScoreDocs;
}
if (newScoreDocs.length == 0) {
return sourceScoreDocs;
}
if (Objects.requireNonNull(sourceScoreDocs, "score docs cannot be null").length < MIN_NUMBER_OF_ELEMENTS_IN_SCORE_DOC
|| Objects.requireNonNull(newScoreDocs, "score docs cannot be null").length < MIN_NUMBER_OF_ELEMENTS_IN_SCORE_DOC) {
throw new IllegalArgumentException("cannot merge top docs because it does not have enough elements");
Expand Down
Loading