Skip to content

Conversation

@ryanbogan
Copy link
Member

@ryanbogan ryanbogan commented Jan 26, 2024

Description

Fixes markdown formatting in the developer guide, through accidental removal of ``` in #1415

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Member

@VijayanB VijayanB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@codecov
Copy link

codecov bot commented Jan 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (47728ce) 84.92% compared to head (025d9ed) 84.88%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1426      +/-   ##
============================================
- Coverage     84.92%   84.88%   -0.04%     
- Complexity     1274     1275       +1     
============================================
  Files           167      167              
  Lines          5186     5186              
  Branches        491      491              
============================================
- Hits           4404     4402       -2     
- Misses          573      576       +3     
+ Partials        209      208       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ryanbogan ryanbogan merged commit d5538a4 into opensearch-project:main Jan 26, 2024
@ryanbogan ryanbogan deleted the fix_developer_guide branch January 26, 2024 21:01
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 26, 2024
Signed-off-by: Ryan Bogan <[email protected]>
(cherry picked from commit d5538a4)
junqiu-lei pushed a commit that referenced this pull request Jan 26, 2024
Signed-off-by: Ryan Bogan <[email protected]>
(cherry picked from commit d5538a4)

Co-authored-by: Ryan Bogan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants