Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement][opensearch] Allow user-defined labels on ingress resource #394

Closed
jwitko opened this issue Mar 2, 2023 · 3 comments · Fixed by #390
Closed

[Enhancement][opensearch] Allow user-defined labels on ingress resource #394

jwitko opened this issue Mar 2, 2023 · 3 comments · Fixed by #390
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jwitko
Copy link
Contributor

jwitko commented Mar 2, 2023

Is your feature request related to a problem? Please describe.
I am using external-dns with settings that makes it label-driven instead of annotation-driven. Because opensearch does not allow me to add user-defined labels to the ingress I cannot get external-dns to pick up the opensearch ingress and automatically create a DNS entry for the endpoint.

Describe the solution you'd like
I would like to be able to add user-defined labels in a similar fashion as annotations to the ingress resource created by the helm chart.

Describe alternatives you've considered
N/A

@jwitko jwitko added enhancement New feature or request untriaged Issues that have not yet been triaged labels Mar 2, 2023
@prudhvigodithi prudhvigodithi added good first issue Good for newcomers and removed untriaged Issues that have not yet been triaged labels Mar 7, 2023
@prudhvigodithi
Copy link
Member

Hey @jwitko thanks for raising an issue, I see your problem, this should be an easy fix, just like how it was added to service labels, we should add the same way to ingress and then you can pass the external-dns label that can added to ingress file, are you open to raise a PR?
Thank you
@bbarani @rishabh6788

@jwitko
Copy link
Contributor Author

jwitko commented Mar 7, 2023

@prudhvigodithi I already created the PR. It is attached to this Issue linked above. #390

@prudhvigodithi
Copy link
Member

Thanks @jwitko I will take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants