-
Notifications
You must be signed in to change notification settings - Fork 626
[Star-tree] Support for nested aggs & Removing experimental flag. #10132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nested aggs support Signed-off-by: Sandesh Kumar <[email protected]>
Signed-off-by: Sandesh Kumar <[email protected]>
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
Signed-off-by: Sandesh Kumar <[email protected]>
Signed-off-by: Sandesh Kumar <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
| ## Using queries without a star-tree index | ||
| #### Nested aggregations | ||
|
|
||
| Set the `indices.composite_index.star_tree.enabled` setting to `false` to run queries without using a star-tree index. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kolchfa-aws We should not remove this section. We need to still give the user an option to disable index search via star-tree.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll incorporate it into the "enabling" section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we kindly keep this a separate section. Today with feature flag removal, and cluster setting pointing to true, its by default enabled. So its not coming out clearly that this can be done. Also we have added index level setting so adding the info in separate section will be useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
_search-plugins/star-tree-index.md
Outdated
|
|
||
| - Set the feature flag `opensearch.experimental.feature.composite_index.star_tree.enabled` to `true`. For more information about enabling and disabling feature flags, see [Enabling experimental features]({{site.url}}{{site.baseurl}}/install-and-configure/configuring-opensearch/experimental/). | ||
| - Set the `indices.composite_index.star_tree.enabled` setting to `true`. For instructions on how to configure OpenSearch, see [Configuring settings]({{site.url}}{{site.baseurl}}/install-and-configure/configuring-opensearch/index/#static-settings). | ||
| - Set the `indices.composite_index.star_tree.enabled` setting to `true`. For more information, see [Dynamic settings]({{site.url}}{{site.baseurl}}/install-and-configure/configuring-opensearch/index/#dynamic-settings). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - Set the `indices.composite_index.star_tree.enabled` setting to `true`. For more information, see [Dynamic settings]({{site.url}}{{site.baseurl}}/install-and-configure/configuring-opensearch/index/#dynamic-settings). |
Signed-off-by: kolchfa-aws <[email protected]>
_search-plugins/star-tree-index.md
Outdated
|
|
||
| - Enable a star-tree index only for indexes whose data is not updated or deleted: star-tree indexes do not support updates or deletions. To enforce this policy, set `index.append_only.enabled` to `true` for the index you want to enable star-tree index on. | ||
| - Use a star-tree index for aggregation queries only if the queried fields are a subset of the star-tree's dimensions and the aggregated fields are a subset of the star-tree's metrics. | ||
| - Once enabled, a star-tree index cannot be disabled. In order to disable a star-tree index, the data in the index must be reindexed without the star-tree mapping. Changing a star-tree configuration also requires reindexing data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding 6848b61#r2162545785.
I think this is a good place to include this information. Something like "Searches using star-tree can however be disabled by this setting.
Basically setting indices.composite_index.star_tree.enabled to false will still create index structures related to star-tree however, the searches will be directed to default path. I'm not sure how to frame this information in a ncie way. @kolchfa-aws Please feel free to reword this section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Reworded.
Signed-off-by: Fanit Kolchina <[email protected]>
|
Thanks @kolchfa-aws for rewording the pages. Looks neat now. Please move to editorial section. |
Signed-off-by: Fanit Kolchina <[email protected]>
kolchfa-aws
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @sandeshkr419! Moving on to editorial review.
_search-plugins/star-tree-index.md
Outdated
|
|
||
| This is an experimental feature and is not recommended for use in a production environment. For updates on the progress of the feature or if you want to leave feedback, join the discussion on the [OpenSearch forum](https://forum.opensearch.org/). | ||
| {: .warning} | ||
| A _star-tree index_ is a multi-field index that improves the performance of aggregations by precomputing metric values for combinations of dimension fields. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: _star-tree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also for index_
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its putting the words in italic font : _italic font_
_search-plugins/star-tree-index.md
Outdated
| - Star-tree indexes are created in real time as part of the indexing process, so the data in a star-tree will always be up to date. | ||
| - A star-tree index consolidates data, increasing index paging efficiency and using less IO for search queries. | ||
| - Star-tree indexes are created in real time as part of the indexing process, so the data in a star-tree is always current. | ||
| - A star-tree index consolidates data to improve paging efficiency and reduce disk I/O during search queries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated to this PR.
What does Consolidates mean here ? The aggregation/pre-cubing from raw documents to create StarTreeDocuments that are unique ?
Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
Signed-off-by: Fanit Kolchina <[email protected]>
natebower
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editorial review
Signed-off-by: Nathan Bower <[email protected]>
Signed-off-by: Sandesh Kumar <[email protected]>
sandeshkr419
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kolchfa-aws I have addressed the technical comments by @bharath-techie & @expani.
Please take a look now.
| ## Using queries without a star-tree index | ||
| #### Nested aggregations | ||
|
|
||
| Set the `indices.composite_index.star_tree.enabled` setting to `false` to run queries without using a star-tree index. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Signed-off-by: Fanit Kolchina <[email protected]>
_search-plugins/star-tree-index.md
Outdated
| | `indices.composite_index.star_tree.enabled` | Cluster | `true` | Enables or disables star-tree search optimization across the cluster. | | ||
| | `index.composite_index` | Index | None | Enables star-tree indexing for a specific index. Must be set when creating the index. | | ||
| | `index.append_only.enabled` | Index | None | Required for star-tree indexes. Prevents updates and deletions. Must be `true`. | | ||
| | `index.search.star_tree_index.enabled` | Index | `true` | Enables or disables use of the star-tree index for search queries on this index. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"this" => "the"
Signed-off-by: kolchfa-aws <[email protected]>
Signed-off-by: kolchfa-aws <[email protected]>
…ensearch-project#10132) * Update star-tree-index.md nested aggs support Signed-off-by: Sandesh Kumar <[email protected]> * remove experimental banner Signed-off-by: Sandesh Kumar <[email protected]> * title capital letter error Signed-off-by: Sandesh Kumar <[email protected]> * remove experimental flag setting Signed-off-by: Sandesh Kumar <[email protected]> * Doc review Signed-off-by: Fanit Kolchina <[email protected]> * Update _search-plugins/star-tree-index.md Signed-off-by: kolchfa-aws <[email protected]> * Incorporate disabling star-tree in enabling section Signed-off-by: Fanit Kolchina <[email protected]> * Restructure limitations Signed-off-by: Fanit Kolchina <[email protected]> * Rewrite enabling section Signed-off-by: Fanit Kolchina <[email protected]> * More rewording Signed-off-by: Fanit Kolchina <[email protected]> * Add cross-links Signed-off-by: Fanit Kolchina <[email protected]> * Minor rewording Signed-off-by: Fanit Kolchina <[email protected]> * Apply suggestions from code review Signed-off-by: Nathan Bower <[email protected]> * Address technical comments Signed-off-by: Sandesh Kumar <[email protected]> * doc review Signed-off-by: Fanit Kolchina <[email protected]> * Update _search-plugins/star-tree-index.md Signed-off-by: kolchfa-aws <[email protected]> * Update _search-plugins/star-tree-index.md Signed-off-by: kolchfa-aws <[email protected]> --------- Signed-off-by: Sandesh Kumar <[email protected]> Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Signed-off-by: Nathan Bower <[email protected]> Co-authored-by: Fanit Kolchina <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: apple <[email protected]>
…ensearch-project#10132) * Update star-tree-index.md nested aggs support Signed-off-by: Sandesh Kumar <[email protected]> * remove experimental banner Signed-off-by: Sandesh Kumar <[email protected]> * title capital letter error Signed-off-by: Sandesh Kumar <[email protected]> * remove experimental flag setting Signed-off-by: Sandesh Kumar <[email protected]> * Doc review Signed-off-by: Fanit Kolchina <[email protected]> * Update _search-plugins/star-tree-index.md Signed-off-by: kolchfa-aws <[email protected]> * Incorporate disabling star-tree in enabling section Signed-off-by: Fanit Kolchina <[email protected]> * Restructure limitations Signed-off-by: Fanit Kolchina <[email protected]> * Rewrite enabling section Signed-off-by: Fanit Kolchina <[email protected]> * More rewording Signed-off-by: Fanit Kolchina <[email protected]> * Add cross-links Signed-off-by: Fanit Kolchina <[email protected]> * Minor rewording Signed-off-by: Fanit Kolchina <[email protected]> * Apply suggestions from code review Signed-off-by: Nathan Bower <[email protected]> * Address technical comments Signed-off-by: Sandesh Kumar <[email protected]> * doc review Signed-off-by: Fanit Kolchina <[email protected]> * Update _search-plugins/star-tree-index.md Signed-off-by: kolchfa-aws <[email protected]> * Update _search-plugins/star-tree-index.md Signed-off-by: kolchfa-aws <[email protected]> --------- Signed-off-by: Sandesh Kumar <[email protected]> Signed-off-by: Fanit Kolchina <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Signed-off-by: Nathan Bower <[email protected]> Co-authored-by: Fanit Kolchina <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Co-authored-by: Nathan Bower <[email protected]> Signed-off-by: Eric Pugh <[email protected]>
Description
Nested Aggs was added and experimental feature flag was removed in 3.1 for star-tree:
opensearch-project/OpenSearch#18048
opensearch-project/OpenSearch#18070
Issues Resolved
Closes #[delete this text, including the brackets, and replace with the issue number]
Version
3.1
Frontend features
If you're submitting documentation for an OpenSearch Dashboards feature, add a video that shows how a user will interact with the UI step by step. A voiceover is optional.
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.