From 4787fc9eeca50074943f0840f34381febabca899 Mon Sep 17 00:00:00 2001 From: sumukhswamy Date: Mon, 14 Aug 2023 17:53:37 -0700 Subject: [PATCH 1/4] added code for the change of design of the sidebar, fixed overriding spinner bug, changed font size Signed-off-by: sumukhswamy --- .../components/event_analytics/explorer/explorer.tsx | 1 + .../event_analytics/explorer/sidebar/field.tsx | 8 ++++---- .../event_analytics/explorer/sidebar/sidebar.scss | 4 ++++ .../event_analytics/explorer/sidebar/sidebar.tsx | 12 ++++++++---- 4 files changed, 17 insertions(+), 8 deletions(-) diff --git a/public/components/event_analytics/explorer/explorer.tsx b/public/components/event_analytics/explorer/explorer.tsx index 9ceaaa9f44..a0c829fbae 100644 --- a/public/components/event_analytics/explorer/explorer.tsx +++ b/public/components/event_analytics/explorer/explorer.tsx @@ -642,6 +642,7 @@ export const Explorer = ({ isOverridingTimestamp, query, isLiveTailOnRef.current, + isOverridingPattern, ]); const visualizations: IVisualizationContainerProps = useMemo(() => { diff --git a/public/components/event_analytics/explorer/sidebar/field.tsx b/public/components/event_analytics/explorer/sidebar/field.tsx index 2b18be672b..521976d8cb 100644 --- a/public/components/event_analytics/explorer/sidebar/field.tsx +++ b/public/components/event_analytics/explorer/sidebar/field.tsx @@ -83,7 +83,7 @@ export const Field = (props: IFieldProps) => { Default Pattern ) : isOverridingPattern ? ( - + ) : ( { Default Timestamp ) : isOverridingTimestamp ? ( - + ) : ( { panelClassName="dscSidebarItem__fieldPopoverPanel" button={ } diff --git a/public/components/event_analytics/explorer/sidebar/sidebar.scss b/public/components/event_analytics/explorer/sidebar/sidebar.scss index cc9557c25f..7190dc3b48 100644 --- a/public/components/event_analytics/explorer/sidebar/sidebar.scss +++ b/public/components/event_analytics/explorer/sidebar/sidebar.scss @@ -124,3 +124,7 @@ .ws__configPanel--right{ overflow-y: unset; } + +.dscSidebar__item{ + white-space: nowrap; +} \ No newline at end of file diff --git a/public/components/event_analytics/explorer/sidebar/sidebar.tsx b/public/components/event_analytics/explorer/sidebar/sidebar.tsx index f949047f56..620df9de5a 100644 --- a/public/components/event_analytics/explorer/sidebar/sidebar.tsx +++ b/public/components/event_analytics/explorer/sidebar/sidebar.tsx @@ -6,7 +6,7 @@ import React, { useState, useCallback, useContext } from 'react'; import { batch, useDispatch } from 'react-redux'; import { isEmpty } from 'lodash'; -import { EuiTitle, EuiSpacer, EuiFieldSearch, EuiAccordion } from '@elastic/eui'; +import { EuiTitle, EuiSpacer, EuiFieldSearch, EuiAccordion, EuiHorizontalRule } from '@elastic/eui'; import { I18nProvider } from '@osd/i18n/react'; import { Field } from './field'; import { ExplorerFields, IExplorerFields, IField } from '../../../../../common/types/explorer'; @@ -108,6 +108,7 @@ export const Sidebar = (props: ISidebarProps) => { }, [explorerFields, tabId] ); + console.log('sidebar ',isOverridingPattern) return ( @@ -134,12 +135,13 @@ export const Sidebar = (props: ISidebarProps) => { initialIsOpen id="fieldSelector__queriedFields" buttonContent={ - + Query fields } paddingSize="xs" > +
    { initialIsOpen id="fieldSelector__selectedFields" buttonContent={ - + Selected Fields } paddingSize="xs" > +
      { initialIsOpen id="fieldSelector__availableFields" buttonContent={ - + Available Fields } paddingSize="xs" > +
        Date: Tue, 15 Aug 2023 10:12:00 -0700 Subject: [PATCH 2/4] addressed PR comments Signed-off-by: sumukhswamy --- .../event_analytics/explorer/sidebar/sidebar.scss | 2 +- .../event_analytics/explorer/sidebar/sidebar.tsx | 7 +++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/public/components/event_analytics/explorer/sidebar/sidebar.scss b/public/components/event_analytics/explorer/sidebar/sidebar.scss index 7190dc3b48..00cf3718a8 100644 --- a/public/components/event_analytics/explorer/sidebar/sidebar.scss +++ b/public/components/event_analytics/explorer/sidebar/sidebar.scss @@ -125,6 +125,6 @@ overflow-y: unset; } -.dscSidebar__item{ +.sidebar_content{ white-space: nowrap; } \ No newline at end of file diff --git a/public/components/event_analytics/explorer/sidebar/sidebar.tsx b/public/components/event_analytics/explorer/sidebar/sidebar.tsx index 620df9de5a..00b0449155 100644 --- a/public/components/event_analytics/explorer/sidebar/sidebar.tsx +++ b/public/components/event_analytics/explorer/sidebar/sidebar.tsx @@ -108,7 +108,6 @@ export const Sidebar = (props: ISidebarProps) => { }, [explorerFields, tabId] ); - console.log('sidebar ',isOverridingPattern) return ( @@ -153,7 +152,7 @@ export const Sidebar = (props: ISidebarProps) => {
      • {
      • {
      • Date: Tue, 15 Aug 2023 10:25:12 -0700 Subject: [PATCH 3/4] code for overriding pattern Signed-off-by: sumukhswamy --- public/components/event_analytics/explorer/explorer.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/public/components/event_analytics/explorer/explorer.tsx b/public/components/event_analytics/explorer/explorer.tsx index a0c829fbae..be6030da5b 100644 --- a/public/components/event_analytics/explorer/explorer.tsx +++ b/public/components/event_analytics/explorer/explorer.tsx @@ -642,7 +642,7 @@ export const Explorer = ({ isOverridingTimestamp, query, isLiveTailOnRef.current, - isOverridingPattern, + isOverridingPattern ]); const visualizations: IVisualizationContainerProps = useMemo(() => { From 5a3ab84282908ff2292f9a78ae4197e94f39caa6 Mon Sep 17 00:00:00 2001 From: sumukhswamy Date: Wed, 16 Aug 2023 13:32:26 -0700 Subject: [PATCH 4/4] updated snapshots Signed-off-by: sumukhswamy --- .../__snapshots__/field.test.tsx.snap | 10 +- .../__snapshots__/sidebar.test.tsx.snap | 351 ++++++++++-------- 2 files changed, 191 insertions(+), 170 deletions(-) diff --git a/public/components/event_analytics/explorer/sidebar/__tests__/__snapshots__/field.test.tsx.snap b/public/components/event_analytics/explorer/sidebar/__tests__/__snapshots__/field.test.tsx.snap index 8ec133b20d..a94df6beba 100644 --- a/public/components/event_analytics/explorer/sidebar/__tests__/__snapshots__/field.test.tsx.snap +++ b/public/components/event_analytics/explorer/sidebar/__tests__/__snapshots__/field.test.tsx.snap @@ -21,7 +21,7 @@ exports[`Field component Renders a sidebar field 1`] = ` anchorPosition="rightUp" button={ @@ -87,7 +87,7 @@ exports[`Field component Renders a sidebar field 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" /> } closePopover={[Function]} @@ -105,7 +105,7 @@ exports[`Field component Renders a sidebar field 1`] = ` className="euiPopover__anchor" > @@ -171,10 +171,10 @@ exports[`Field component Renders a sidebar field 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" >
      • @@ -1118,7 +1125,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` anchorPosition="rightUp" button={ @@ -1173,7 +1180,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" /> } closePopover={[Function]} @@ -1191,7 +1198,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` className="euiPopover__anchor" > @@ -1246,10 +1253,10 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" >
      • @@ -1437,7 +1444,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` anchorPosition="rightUp" button={ @@ -1492,7 +1499,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" /> } closePopover={[Function]} @@ -1510,7 +1517,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` className="euiPopover__anchor" > @@ -1565,10 +1572,10 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" >
      • @@ -1756,7 +1763,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` anchorPosition="rightUp" button={ @@ -1811,7 +1818,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" /> } closePopover={[Function]} @@ -1829,7 +1836,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` className="euiPopover__anchor" > @@ -1884,10 +1891,10 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" >
      • @@ -2075,7 +2082,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` anchorPosition="rightUp" button={ @@ -2130,7 +2137,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" /> } closePopover={[Function]} @@ -2148,7 +2155,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` className="euiPopover__anchor" > @@ -2203,10 +2210,10 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" >
      • @@ -2394,7 +2401,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` anchorPosition="rightUp" button={ @@ -2449,7 +2456,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" /> } closePopover={[Function]} @@ -2467,7 +2474,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` className="euiPopover__anchor" > @@ -2522,10 +2529,10 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" >
      • @@ -3316,7 +3337,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` anchorPosition="rightUp" button={ @@ -3370,7 +3391,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" /> } closePopover={[Function]} @@ -3388,7 +3409,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` className="euiPopover__anchor" > @@ -3442,10 +3463,10 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" >
      • @@ -3633,7 +3654,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` anchorPosition="rightUp" button={ @@ -3687,7 +3708,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" /> } closePopover={[Function]} @@ -3705,7 +3726,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` className="euiPopover__anchor" > @@ -3759,10 +3780,10 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" >
      • @@ -3950,7 +3971,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` anchorPosition="rightUp" button={ @@ -4004,7 +4025,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" /> } closePopover={[Function]} @@ -4022,7 +4043,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` className="euiPopover__anchor" > @@ -4076,10 +4097,10 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" >
      • @@ -4267,7 +4288,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` anchorPosition="rightUp" button={ @@ -4333,7 +4354,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" /> } closePopover={[Function]} @@ -4351,7 +4372,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` className="euiPopover__anchor" > @@ -4417,10 +4438,10 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" >
      • @@ -4655,7 +4676,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` anchorPosition="rightUp" button={ @@ -4709,7 +4730,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" /> } closePopover={[Function]} @@ -4727,7 +4748,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` className="euiPopover__anchor" > @@ -4781,10 +4802,10 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" >
      • @@ -4972,7 +4993,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` anchorPosition="rightUp" button={ @@ -5038,7 +5059,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" /> } closePopover={[Function]} @@ -5056,7 +5077,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` className="euiPopover__anchor" > @@ -5122,10 +5143,10 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" >
      • @@ -5360,7 +5381,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` anchorPosition="rightUp" button={ @@ -5426,7 +5447,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" /> } closePopover={[Function]} @@ -5444,7 +5465,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` className="euiPopover__anchor" > @@ -5510,10 +5531,10 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" >
      • @@ -5748,7 +5769,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` anchorPosition="rightUp" button={ @@ -5802,7 +5823,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" /> } closePopover={[Function]} @@ -5820,7 +5841,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` className="euiPopover__anchor" > @@ -5874,10 +5895,10 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" >
      • @@ -6065,7 +6086,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` anchorPosition="rightUp" button={ @@ -6119,7 +6140,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" /> } closePopover={[Function]} @@ -6137,7 +6158,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` className="euiPopover__anchor" > @@ -6191,10 +6212,10 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" >
      • @@ -6382,7 +6403,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` anchorPosition="rightUp" button={ @@ -6436,7 +6457,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" /> } closePopover={[Function]} @@ -6454,7 +6475,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` className="euiPopover__anchor" > @@ -6508,10 +6529,10 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" >
      • @@ -6699,7 +6720,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` anchorPosition="rightUp" button={ @@ -6765,7 +6786,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" /> } closePopover={[Function]} @@ -6783,7 +6804,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` className="euiPopover__anchor" > @@ -6849,10 +6870,10 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" >
      • @@ -7087,7 +7108,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` anchorPosition="rightUp" button={ @@ -7141,7 +7162,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" /> } closePopover={[Function]} @@ -7159,7 +7180,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` className="euiPopover__anchor" > @@ -7213,10 +7234,10 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" >
      • @@ -7404,7 +7425,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` anchorPosition="rightUp" button={ @@ -7470,7 +7491,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" /> } closePopover={[Function]} @@ -7488,7 +7509,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` className="euiPopover__anchor" > @@ -7554,10 +7575,10 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" >
      • @@ -7792,7 +7813,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` anchorPosition="rightUp" button={ @@ -7858,7 +7879,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" /> } closePopover={[Function]} @@ -7876,7 +7897,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` className="euiPopover__anchor" > @@ -7942,10 +7963,10 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" >
      • @@ -8180,7 +8201,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` anchorPosition="rightUp" button={ @@ -8246,7 +8267,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" /> } closePopover={[Function]} @@ -8264,7 +8285,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` className="euiPopover__anchor" > @@ -8330,10 +8351,10 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" >
      • @@ -8568,7 +8589,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` anchorPosition="rightUp" button={ @@ -8634,7 +8655,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" /> } closePopover={[Function]} @@ -8652,7 +8673,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` className="euiPopover__anchor" > @@ -8718,10 +8739,10 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" >
      • @@ -8956,7 +8977,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` anchorPosition="rightUp" button={ @@ -9016,7 +9037,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" /> } closePopover={[Function]} @@ -9034,7 +9055,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` className="euiPopover__anchor" > @@ -9094,10 +9115,10 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" >
      • @@ -9296,7 +9317,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` anchorPosition="rightUp" button={ @@ -9362,7 +9383,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" /> } closePopover={[Function]} @@ -9380,7 +9401,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` className="euiPopover__anchor" > @@ -9446,10 +9467,10 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" >
      • @@ -9684,7 +9705,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` anchorPosition="rightUp" button={ @@ -9750,7 +9771,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" /> } closePopover={[Function]} @@ -9768,7 +9789,7 @@ exports[`Siderbar component Renders sidebar component 1`] = ` className="euiPopover__anchor" > @@ -9834,10 +9855,10 @@ exports[`Siderbar component Renders sidebar component 1`] = ` } isActive={false} onClick={[Function]} - size="m" + size="s" >