[Backport 2.x] Support any channel types from Notification #748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Support any channel types from Notification Signed-off-by: Ashish Agrawal <[email protected]> * Remove unused CHANNEL_TYPES constant Signed-off-by: Ashish Agrawal <[email protected]> * Return empty array if failed to get features Signed-off-by: Ashish Agrawal <[email protected]> --------- Signed-off-by: Ashish Agrawal <[email protected]> (cherry picked from commit 1c7239f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## 2.x #748 +/- ##
==========================================
- Coverage 49.85% 49.84% -0.01%
==========================================
Files 233 232 -1
Lines 6561 6558 -3
Branches 939 940 +1
==========================================
- Hits 3271 3269 -2
+ Misses 3287 3286 -1
Partials 3 3 |
lezzago
approved these changes
Oct 2, 2023
AWSHurneyt
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1c7239f from #743.