[Backport] [2.x] Fixed misunderstanding message 'No OpenSearchException found' when detailed_error disabled #4708

xuezhou25 · 2022-10-07T17:30:48Z

Signed-off-by: Xue Zhou [email protected]

Description

Backport #4669

Issues Resolved

[List any issues this PR will resolve]

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…tailed_error disabled Signed-off-by: Xue Zhou <[email protected]>

github-actions · 2022-10-07T17:49:31Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/4156/
CommitID: ed4a6de

dreamer-89 · 2022-10-07T17:51:02Z

CHANGELOG.md

 - Fixed the SnapshotsInProgress error during index deletion ([#4570](https://github.com/opensearch-project/OpenSearch/pull/4570))
 - [Bug]: Fixed invalid location of JDK dependency for arm64 architecture([#4613](https://github.com/opensearch-project/OpenSearch/pull/4613))
 - [Bug]: Alias filter lost after rollover ([#4499](https://github.com/opensearch-project/OpenSearch/pull/4499))
+- Fixed misunderstanding message "No OpenSearchException found" when detailed_error disabled ([#4669](https://github.com/opensearch-project/OpenSearch/pull/4669))


Thanks @xuezhou25 for the fix.

Please change PR number 4669 -> 4708

We can update the wording to make it more clear.

dreamer-89 · 2022-10-07T17:57:37Z

The PR is failing because of recent version bump in 1.x from 1.3.6 -> 1.3.7 as part of #4701. We need to update the same in 2.x. Once that PR is merged to 2.x, you need to rebase against

1: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':distribution:bwc:maintenance:buildBwcLinuxTar'.
> Building 1.3.6 didn't generate expected file /var/jenkins/workspace/gradle-check/search/distribution/bwc/maintenance/build/bwc/checkout-1.3/distribution/archives/linux-tar/build/distributions/opensearch-min-1.3.6-SNAPSHOT-linux-x64.tar.gz

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.

dreamer-89 · 2022-10-07T20:20:46Z

@xuezhou25 : Can you please rebase against latest 2.x branch ? It should fix the bwc test failures.

nknize · 2022-10-07T20:51:34Z

server/src/main/java/org/opensearch/OpenSearchException.java

                t = t.getCause();
            }
-            builder.field(ERROR, message);
+            builder.field(ERROR, ExceptionsHelper.summaryMessage(t));


Suggested change

builder.field(ERROR, ExceptionsHelper.summaryMessage(t));

builder.field(ERROR, ExceptionsHelper.summaryMessage(e));

t is null, which results in a more confusing Internal error exception even when a useful IllegalArgumentException is thrown. e should be passed to summaryMessage so a more useful message is thrown. This already resulted in a reproducible test failure which was fixed in #4702.

@nknize I think the logic behind this code is to find the OpenSearchException down the cause chain (which is t). May be in this case we should do:

builder.field(ERROR, ExceptionsHelper.summaryMessage(t != null ? t : e));

?

Thanks for reviewing. I will do this fix

I agree with the suggested change from @reta . The original logic is to find the OpenSearchException down the cause chain, and show its error message.
Looks like if the code is changed to t != null ? t : e here in 2.x branch, then the corresponding change also need to be applied in main branch.

OpenSearch/server/src/main/java/org/opensearch/OpenSearchException.java

Line 591 in f051131

builder.field(ERROR, ExceptionsHelper.summaryMessage(e));

The ExceptionsHelper.summaryMessage(e) version is what exists on main currently. We should probably keep them consistent and then follow up with a change on main to do the ExceptionsHelper.summaryMessage(t != null ? t : e) version (and then backport that PR as well).

@andrross Make sense, thank you! 😄

Signed-off-by: Xue Zhou <[email protected]>

github-actions · 2022-10-10T17:59:46Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/4293/
CommitID: 3125135

github-actions · 2022-10-10T18:05:40Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/4294/
CommitID: b0a62b7

github-actions · 2022-10-10T23:53:27Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/4342/
CommitID: b0a62b7

andrross · 2022-11-02T16:10:30Z

@xuezhou25 Can you rebase and fix changelog conflicts?

# Conflicts: # CHANGELOG.md

Signed-off-by: Xue Zhou <[email protected]>

github-actions · 2022-11-04T03:27:06Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/6334/
CommitID: 461000d
Please examine the workflow log, locate, and copy-paste the failure below, then iterate to green.
Is the failure a flaky test unrelated to your change?

Signed-off-by: Xue Zhou <[email protected]>

github-actions · 2022-11-04T03:37:23Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/6335/
CommitID: c289c22
Please examine the workflow log, locate, and copy-paste the failure below, then iterate to green.
Is the failure a flaky test unrelated to your change?

The comment of changelog has been resolved.

github-actions · 2022-11-04T04:15:00Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/6336/
CommitID: 702cb9c
Please examine the workflow log, locate, and copy-paste the failure below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2022-11-04T04:23:17Z

Gradle Check (Jenkins) Run Completed with:

RESULT: UNSTABLE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/6337/
CommitID: 626d22c
Please examine the workflow log, locate, and copy-paste the failure below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2022-11-04T05:18:37Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/6342/
CommitID: 626d22c
Please examine the workflow log, locate, and copy-paste the failure below, then iterate to green.
Is the failure a flaky test unrelated to your change?

The suggested change about ExceptionsHelper.summaryMessage(e) has been applied.

github-actions · 2022-11-04T06:13:56Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/6344/
CommitID: 626d22c

codecov-commenter · 2022-11-04T06:16:24Z

Codecov Report

Merging #4708 (626d22c) into 2.x (12d9175) will decrease coverage by 0.12%.
The diff coverage is 62.60%.

@@             Coverage Diff              @@
##                2.x    #4708      +/-   ##
============================================
- Coverage     70.78%   70.65%   -0.13%     
- Complexity    57706    58244     +538     
============================================
  Files          4620     4695      +75     
  Lines        276221   278823    +2602     
  Branches      40422    40726     +304     
============================================
+ Hits         195511   197012    +1501     
- Misses        64391    65336     +945     
- Partials      16319    16475     +156

Impacted Files	Coverage Δ
...a/org/opensearch/gradle/test/DistroTestPlugin.java	`0.00% <ø> (ø)`
.../java/org/opensearch/painless/ScriptClassInfo.java	`83.01% <0.00%> (ø)`
.../delete/DeleteDecommissionStateRequestBuilder.java	`0.00% <0.00%> (ø)`
...reness/get/GetDecommissionStateRequestBuilder.java	`0.00% <0.00%> (ø)`
...sion/awareness/put/DecommissionRequestBuilder.java	`0.00% <0.00%> (ø)`
...te/ClusterDeleteWeightedRoutingRequestBuilder.java	`0.00% <0.00%> (ø)`
...eighted/put/ClusterPutWeightedRoutingResponse.java	`0.00% <0.00%> (ø)`
...min/cluster/stats/TransportClusterStatsAction.java	`70.83% <ø> (ø)`
.../org/opensearch/client/support/AbstractClient.java	`32.54% <0.00%> (-2.22%)`	⬇️
...rg/opensearch/common/settings/ClusterSettings.java	`91.89% <ø> (ø)`
... and 592 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

…on found' when detailed_error disabled (#4708) * Fixed misunderstanding message 'No OpenSearchException found' when detailed_error disabled Signed-off-by: Xue Zhou <[email protected]> (cherry picked from commit 802e693)

…on found' when detailed_error disabled (#4708) (#5073) * Fixed misunderstanding message 'No OpenSearchException found' when detailed_error disabled Signed-off-by: Xue Zhou <[email protected]> (cherry picked from commit 802e693) Co-authored-by: Xue Zhou <[email protected]>

Fixed misunderstanding message 'No OpenSearchException found' when de…

ed4a6de

…tailed_error disabled Signed-off-by: Xue Zhou <[email protected]>

xuezhou25 requested review from a team and reta as code owners October 7, 2022 17:30

dreamer-89 previously requested changes Oct 7, 2022

View reviewed changes

tlfeng added enhancement Enhancement or improvement to existing feature or request backport PRs or issues specific to backporting features or enhancments v2.4.0 'Issues and PRs related to version v2.4.0' labels Oct 7, 2022

tlfeng mentioned this pull request Oct 7, 2022

[2.x] Add BWC version 1.3.7 #4709

Merged

6 tasks

nknize previously requested changes Oct 7, 2022

View reviewed changes

xuezhou25 added 2 commits October 10, 2022 10:19

Merge branch '2.x' into 2.x_fix_detailed_error_message_showing

3125135

Fix summaryMessage value

b0a62b7

Signed-off-by: Xue Zhou <[email protected]>

xuezhou25 requested review from dreamer-89 and nknize October 11, 2022 17:15

xuezhou25 added 4 commits November 3, 2022 20:14

Merge branch '2.x' into 2.x_fix_detailed_error_message_showing

6431cf9

# Conflicts: # CHANGELOG.md

rebase and fix changelog conflicts

e307f32

Signed-off-by: Xue Zhou <[email protected]>

rebase and fix changelog conflicts

461000d

Signed-off-by: Xue Zhou <[email protected]>

fix changelog conflicts

c289c22

Signed-off-by: Xue Zhou <[email protected]>

xuezhou25 added 2 commits November 3, 2022 20:30

fixing merge conflicts

702cb9c

Signed-off-by: Xue Zhou <[email protected]>

Remove changelog duplication

626d22c

Signed-off-by: Xue Zhou <[email protected]>

tlfeng added the backport 2.4 Backport to 2.4 branch label Nov 4, 2022

tlfeng approved these changes Nov 4, 2022

View reviewed changes

tlfeng added backport 2.4 Backport to 2.4 branch and removed backport 2.4 Backport to 2.4 branch labels Nov 4, 2022

xuezhou25 merged commit 802e693 into opensearch-project:2.x Nov 4, 2022

opensearch-trigger-bot bot mentioned this pull request Nov 4, 2022

[Backport 2.4] [Backport] [2.x] Fixed misunderstanding message 'No OpenSearchException found' when detailed_error disabled #5073

Merged

xuezhou25 mentioned this pull request Nov 4, 2022

Change the output error message back to use OpenSearchException in the cause chain #5081

Merged

6 tasks

xuezhou25 deleted the 2.x_fix_detailed_error_message_showing branch November 12, 2022 17:31

	builder.field(ERROR, ExceptionsHelper.summaryMessage(t));
	builder.field(ERROR, ExceptionsHelper.summaryMessage(e));

[Backport] [2.x] Fixed misunderstanding message 'No OpenSearchException found' when detailed_error disabled #4708

[Backport] [2.x] Fixed misunderstanding message 'No OpenSearchException found' when detailed_error disabled #4708

Uh oh!

Conversation

xuezhou25 commented Oct 7, 2022

Description

Issues Resolved

Check List

Uh oh!

github-actions bot commented Oct 7, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

dreamer-89 Oct 7, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dreamer-89 commented Oct 7, 2022

Uh oh!

dreamer-89 commented Oct 7, 2022

Uh oh!

nknize Oct 7, 2022

Choose a reason for hiding this comment

Uh oh!

reta Oct 7, 2022

Choose a reason for hiding this comment

Uh oh!

xuezhou25 Oct 10, 2022

Choose a reason for hiding this comment

Uh oh!

tlfeng Nov 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andrross Nov 4, 2022

Choose a reason for hiding this comment

Uh oh!

tlfeng Nov 4, 2022

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 10, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 10, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Oct 10, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

andrross commented Nov 2, 2022

Uh oh!

github-actions bot commented Nov 4, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Nov 4, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Nov 4, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Nov 4, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Nov 4, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

github-actions bot commented Nov 4, 2022

Gradle Check (Jenkins) Run Completed with:

Uh oh!

codecov-commenter commented Nov 4, 2022

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

dreamer-89 Oct 7, 2022 •

edited

Loading

tlfeng Nov 4, 2022 •

edited

Loading