-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[Pull-based Ingestion] Support message mappers to support different input formats and raw payloads #19765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pull-based Ingestion] Support message mappers to support different input formats and raw payloads #19765
Conversation
3fab3ae to
72773f3
Compare
|
❌ Gradle check result for 72773f3: TIMEOUT Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 72773f3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 72773f3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 72773f3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
72773f3 to
85dae2e
Compare
85dae2e to
e9e9f3f
Compare
|
❌ Gradle check result for e9e9f3f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #19765 +/- ##
============================================
- Coverage 73.23% 73.21% -0.03%
+ Complexity 71544 71539 -5
============================================
Files 5786 5789 +3
Lines 327013 327056 +43
Branches 47284 47288 +4
============================================
- Hits 239498 239462 -36
- Misses 68245 68291 +46
- Partials 19270 19303 +33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
❌ Gradle check result for 6591f14: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Looks like the disabled assertions has something to do with the new unit test file (guessing related to SuppressWarnings). I have currently deleted the file for testing - and hence this PR is not ready for review/merging. |
6591f14 to
8490b5f
Compare
|
❌ Gradle check result for 8490b5f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
8490b5f to
83797ef
Compare
|
❌ Gradle check result for 83797ef: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
4fbea26 to
eb62bc7
Compare
|
❌ Gradle check result for eb62bc7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for eb62bc7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for eb62bc7: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Looks like the problem was another test disabling assertions. Updating it seems to have solved the problem. Thanks @andrross for finding the culprit test! |
Signed-off-by: Varun Bharadwaj <[email protected]>
Signed-off-by: Varun Bharadwaj <[email protected]>
eb62bc7 to
881989d
Compare
|
❌ Gradle check result for 881989d: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…nput formats and raw payloads (opensearch-project#19765) * refactor pull-based ingestion to support message mappers * remove DefaultAssertionStatus false from segment warmer test Signed-off-by: Varun Bharadwaj <[email protected]>
Description
This PR refactors the pull-based indexing flow to support message mappers. A default message mapper is created to retain current behavior. Alternatively, a raw payload mapper is added to support ingesting from any given streaming source.
In the raw payload mode, the Kafka offset / Kinesis sequence number will be used as the document ID. This will ensure duplicate documents are not created on rewind/replay. Document versioning will not be supported, and only an eventually consistent view of documents can be expected on message replays (as older message can potentially overwrite newer one on replay, until the lag is caught up). This will be an append-only indexing mode.
This model should allow the flexibility to support other formats in the future, when needed.
Related Issues
Resolves #19548
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.