-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Disable request cache for streaming and other fixes #19520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable request cache for streaming and other fixes #19520
Conversation
Signed-off-by: Rishabh Maurya <[email protected]>
f8863e8 to
5396dc9
Compare
|
❌ Gradle check result for 5396dc9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
Manual backport 3.3: #19522 |
bowenlan-amzn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would expect a non-null FlushMode when creating aggregator. Will figure out why later.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #19520 +/- ##
============================================
- Coverage 73.09% 72.95% -0.14%
+ Complexity 70553 70458 -95
============================================
Files 5716 5717 +1
Lines 322926 323004 +78
Branches 46770 46784 +14
============================================
- Hits 236032 235639 -393
- Misses 67882 68387 +505
+ Partials 19012 18978 -34 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ct#19520) Signed-off-by: Rishabh Maurya <[email protected]>
Description
When request is streaming aggregation, we should refrain from caching it due to lack of better solution at present.
Independent of this issue, there are couple of other issues with streaming aggregation which are follow up of #19484 -
Need to check flush mode as null or per segment before deciding on StreamCardinalityAggregator in CardinalityAggregatorFactory.
Minor - When profilingAggregator is enabled, flushMode decision doesn't work as expected.
Min, Max aggregator should be Streamable.
Related Issues
Resolves #19518
Check List
- [ ] API changes companion pull request created, if applicable.- [ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.