Skip to content

Conversation

@rishabhmaurya
Copy link
Contributor

Description

When request is streaming aggregation, we should refrain from caching it due to lack of better solution at present.

Independent of this issue, there are couple of other issues with streaming aggregation which are follow up of #19484 -

Need to check flush mode as null or per segment before deciding on StreamCardinalityAggregator in CardinalityAggregatorFactory.
Minor - When profilingAggregator is enabled, flushMode decision doesn't work as expected.
Min, Max aggregator should be Streamable.

Related Issues

Resolves #19518

Check List

  • Functionality includes testing.
    - [ ] API changes companion pull request created, if applicable.
    - [ ] Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2025

❌ Gradle check result for 5396dc9: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@peterzhuamazon
Copy link
Member

Manual backport 3.3: #19522

Copy link
Member

@bowenlan-amzn bowenlan-amzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect a non-null FlushMode when creating aggregator. Will figure out why later.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2025

✅ Gradle check result for 5396dc9: SUCCESS

@codecov
Copy link

codecov bot commented Oct 4, 2025

Codecov Report

❌ Patch coverage is 47.05882% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.95%. Comparing base (ac6dfa1) to head (5396dc9).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...regations/bucket/terms/TermsAggregatorFactory.java 0.00% 0 Missing and 3 partials ⚠️
...egations/metrics/CardinalityAggregatorFactory.java 25.00% 2 Missing and 1 partial ⚠️
...opensearch/search/streaming/FlushModeResolver.java 0.00% 1 Missing and 1 partial ⚠️
...earch/profile/aggregation/ProfilingAggregator.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19520      +/-   ##
============================================
- Coverage     73.09%   72.95%   -0.14%     
+ Complexity    70553    70458      -95     
============================================
  Files          5716     5717       +1     
  Lines        322926   323004      +78     
  Branches      46770    46784      +14     
============================================
- Hits         236032   235639     -393     
- Misses        67882    68387     +505     
+ Partials      19012    18978      -34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Performance Roadmap Oct 4, 2025
@jainankitk jainankitk merged commit cb65261 into opensearch-project:main Oct 4, 2025
34 of 37 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Performance Roadmap Oct 4, 2025
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Oct 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Search Search query, autocomplete ...etc v3.3.0

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[BUG] Streaming aggregation with request cache and other fixes

4 participants