-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Delegate primitive write methods with ByteSizeCachingDirectory wrapped IndexOutput #19432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delegate primitive write methods with ByteSizeCachingDirectory wrapped IndexOutput #19432
Conversation
Signed-off-by: gesong.samuel <[email protected]>
Signed-off-by: gesong.samuel <[email protected]>
|
❌ Gradle check result for 4529b0e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
bugmakerrrrrr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
❕ Gradle check result for 36569ba: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19432 +/- ##
============================================
+ Coverage 72.93% 73.01% +0.07%
- Complexity 69986 70013 +27
============================================
Files 5676 5676
Lines 321224 321230 +6
Branches 46441 46441
============================================
+ Hits 234295 234549 +254
+ Misses 67955 67743 -212
+ Partials 18974 18938 -36 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: gesong.samuel <[email protected]>
|
❌ Gradle check result for f79a919: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❕ Gradle check result for f79a919: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
09d3d26
into
opensearch-project:main
…d IndexOutput (opensearch-project#19432) * init Signed-off-by: gesong.samuel <[email protected]> * change Signed-off-by: gesong.samuel <[email protected]> * change Signed-off-by: gesong.samuel <[email protected]> --------- Signed-off-by: gesong.samuel <[email protected]>
…d IndexOutput (opensearch-project#19432) * init Signed-off-by: gesong.samuel <[email protected]> * change Signed-off-by: gesong.samuel <[email protected]> * change Signed-off-by: gesong.samuel <[email protected]> --------- Signed-off-by: gesong.samuel <[email protected]>
Description
Delegate primitive write methods with ByteSizeCachingDirectory wrapped IndexOutput, so the BKD merge should be speed up
Related Issues
Resolves #19420
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.