Skip to content

Conversation

@HUSTERGS
Copy link
Contributor

Description

Delegate primitive write methods with ByteSizeCachingDirectory wrapped IndexOutput, so the BKD merge should be speed up

Related Issues

Resolves #19420

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: gesong.samuel <[email protected]>
Signed-off-by: gesong.samuel <[email protected]>
@github-actions
Copy link
Contributor

❌ Gradle check result for 4529b0e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

@bugmakerrrrrr bugmakerrrrrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

❕ Gradle check result for 36569ba: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov
Copy link

codecov bot commented Sep 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.01%. Comparing base (5e6ee97) to head (f79a919).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #19432      +/-   ##
============================================
+ Coverage     72.93%   73.01%   +0.07%     
- Complexity    69986    70013      +27     
============================================
  Files          5676     5676              
  Lines        321224   321230       +6     
  Branches      46441    46441              
============================================
+ Hits         234295   234549     +254     
+ Misses        67955    67743     -212     
+ Partials      18974    18938      -36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: gesong.samuel <[email protected]>
@github-actions
Copy link
Contributor

❌ Gradle check result for f79a919: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❕ Gradle check result for f79a919: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@bugmakerrrrrr bugmakerrrrrr merged commit 09d3d26 into opensearch-project:main Sep 28, 2025
34 of 36 checks passed
karenyrx pushed a commit to karenyrx/OpenSearch that referenced this pull request Sep 29, 2025
…d IndexOutput (opensearch-project#19432)

* init

Signed-off-by: gesong.samuel <[email protected]>

* change

Signed-off-by: gesong.samuel <[email protected]>

* change

Signed-off-by: gesong.samuel <[email protected]>

---------

Signed-off-by: gesong.samuel <[email protected]>
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Oct 15, 2025
…d IndexOutput (opensearch-project#19432)

* init

Signed-off-by: gesong.samuel <[email protected]>

* change

Signed-off-by: gesong.samuel <[email protected]>

* change

Signed-off-by: gesong.samuel <[email protected]>

---------

Signed-off-by: gesong.samuel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] ByteSizeCachingDirectory wrapped IndexOutput should delegate primitive write methods

2 participants