Fix issue with updating core with a patch number other than 0 #19377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Contributor
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19377 +/- ##
============================================
- Coverage 73.09% 73.08% -0.01%
- Complexity 70702 70752 +50
============================================
Files 5725 5725
Lines 323795 323793 -2
Branches 46882 46882
============================================
- Hits 236684 236656 -28
- Misses 68013 68108 +95
+ Partials 19098 19029 -69 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Craig Perkins <[email protected]>
Contributor
|
❌ Gradle check result for 891235b: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
This was referenced Sep 23, 2025
Contributor
|
❕ Gradle check result for 891235b: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
sandeshkr419
approved these changes
Oct 13, 2025
Signed-off-by: Craig Perkins <[email protected]>
Member
Author
Done. |
Contributor
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 16, 2025
* Fix issue with updating core with a patch number other than 0 Signed-off-by: Craig Perkins <[email protected]> * Add to CHANGELOG Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 4094287) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Member
|
Backporting to 3.3 branch to facilitate (potential) 3.3.1 patch release. Ref discussion: #19660 |
sandeshkr419
added a commit
that referenced
this pull request
Oct 17, 2025
… than 0 (#19667) * Fix issue with updating core with a patch number other than 0 (#19377) * Fix issue with updating core with a patch number other than 0 Signed-off-by: Craig Perkins <[email protected]> * Add to CHANGELOG Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 4094287) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Update CHANGELOG to remove unwanted Removed several fixed issues from the CHANGELOG. Signed-off-by: Sandesh Kumar <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Sandesh Kumar <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sandesh Kumar <[email protected]>
rgsriram
pushed a commit
to rgsriram/OpenSearch
that referenced
this pull request
Oct 18, 2025
…arch-project#19377) * Fix issue with updating core with a patch number other than 0 Signed-off-by: Craig Perkins <[email protected]> * Add to CHANGELOG Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]>
kh3ra
pushed a commit
to kh3ra/OpenSearch
that referenced
this pull request
Oct 23, 2025
…arch-project#19377) * Fix issue with updating core with a patch number other than 0 Signed-off-by: Craig Perkins <[email protected]> * Add to CHANGELOG Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While researching opensearch-project/opensearch-build#5720, I ran into an issue where I could not version bump the core to 3.3.1 and run
./gradlew localDistrosuccessfully. It would run into the following error:The reason for this is that it hit this block which is only triggered when the minor and patch version are both non-zero. When the patch number is 0 (as it is with any minor version bump) then the condition never gets triggered.
This PR resolves the issue by removing references to the Legacy ES version numbers which are more than 2 major versions in the past at this point.
Related Issues
Related to opensearch-project/opensearch-build#5720
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.