-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[GRPC] Publish transport-grpc-spi for QueryBuilderProtoConverter and QueryBuilderProtoConverterRegistry #18949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
❌ Gradle check result for e709b11: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for eae0332: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for c7bdd89: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18949 +/- ##
============================================
- Coverage 72.92% 72.90% -0.03%
- Complexity 69779 69804 +25
============================================
Files 5665 5667 +2
Lines 320521 320532 +11
Branches 46396 46397 +1
============================================
- Hits 233739 233675 -64
- Misses 67854 68038 +184
+ Partials 18928 18819 -109 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
03c2aa5 to
373f22e
Compare
|
❌ Gradle check result for 373f22e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 43258db: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…y an SPI Signed-off-by: Karen Xu <[email protected]>
Signed-off-by: Karen X <[email protected]>
Signed-off-by: Karen Xu <[email protected]>
|
❌ Gradle check result for 3c79981: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
...i/src/main/java/org/opensearch/transport/grpc/spi/QueryBuilderProtoConverterSpiRegistry.java
Show resolved
Hide resolved
Signed-off-by: Karen Xu <[email protected]>
|
❌ Gradle check result for 42762d1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Karen X <[email protected]>
|
❌ Gradle check result for 5082498: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Karen X <[email protected]>
msfroh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this interface a lot now. It's a really simple and elegant way to hook in new proto converters.
Thanks @karenyrx!
Signed-off-by: Michael Froh <[email protected]>
|
❌ Gradle check result for 2c59866: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
…QueryBuilderProtoConverterRegistry (opensearch-project#18949) --------- Signed-off-by: Karen Xu <[email protected]> Signed-off-by: Karen X <[email protected]> Signed-off-by: Michael Froh <[email protected]> Co-authored-by: Michael Froh <[email protected]>
…QueryBuilderProtoConverterRegistry (opensearch-project#18949) --------- Signed-off-by: Karen Xu <[email protected]> Signed-off-by: Karen X <[email protected]> Signed-off-by: Michael Froh <[email protected]> Co-authored-by: Michael Froh <[email protected]> Signed-off-by: Ankit Jain <[email protected]>
…QueryBuilderProtoConverterRegistry (opensearch-project#18949) --------- Signed-off-by: Karen Xu <[email protected]> Signed-off-by: Karen X <[email protected]> Signed-off-by: Michael Froh <[email protected]> Co-authored-by: Michael Froh <[email protected]> Signed-off-by: Ankit Jain <[email protected]>
…QueryBuilderProtoConverterRegistry (opensearch-project#18949) --------- Signed-off-by: Karen Xu <[email protected]> Signed-off-by: Karen X <[email protected]> Signed-off-by: Michael Froh <[email protected]> Co-authored-by: Michael Froh <[email protected]>
…QueryBuilderProtoConverterRegistry (opensearch-project#18949) --------- Signed-off-by: Karen Xu <[email protected]> Signed-off-by: Karen X <[email protected]> Signed-off-by: Michael Froh <[email protected]> Co-authored-by: Michael Froh <[email protected]>
…QueryBuilderProtoConverterRegistry (opensearch-project#18949) --------- Signed-off-by: Karen Xu <[email protected]> Signed-off-by: Karen X <[email protected]> Signed-off-by: Michael Froh <[email protected]> Co-authored-by: Michael Froh <[email protected]>
Description
Publish a lighter weight version of the GRPC module into a SPI, exposing only the interfaces needed by external plugins.
Instead of the entire
transport-grpcmodule as a dependency, external plugins can import a lighter weighttransport-grpc-spias a dependency, which only bundlesopensearch-protobufsand:server, rather than the entire grpc lib (including guava).Example PR on how this SPI can be used by external plugins: opensearch-project/k-NN#2833
Test plan
Built and tested interanlly, and GRPC KNN Queries are still working:
(No data was ingested for this test so no vectors are returned)
A sample log on node startup, showing both core Query converters (e.g. MATCH_ALL, MATCH_NONE, TERM, TERMS) as well as external Query converter (e.g. KNN) are being registered:
Related Issues
#18513
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.