[Backport 3.0] Enable concurrent_segment_search auto mode by default #18077
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ject#17978) * Enable concurrent_segment_search auto mode by default Signed-off-by: Vikasht34 <[email protected]> * Make Default Slice count to 1 for Non-Concurrent Path Signed-off-by: Vikasht34 <[email protected]> * Add tolerance to matrix_stats agg correlation value assertion The correlation metric could be different for different document distribution across shards, or slices. slice1(doc1,doc2), slice2(doc3,doc4,doc5) could give different correlation from slice1(doc1,doc2,doc3), slice2(doc4,doc5) The tolerance followed here is 0.000000000000001 Signed-off-by: bowenlan-amzn <[email protected]> --------- Signed-off-by: Vikasht34 <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> Co-authored-by: bowenlan-amzn <[email protected]>
bowenlan-amzn
changed the title
bowenlan-amzn
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
bugmakerrrrrr,
cwperks,
dbwiddis,
gbbafna,
jainankitk,
jed326,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
Contributor
kotwanikunal
approved these changes
Apr 24, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3.0 #18077 +/- ##
============================================
+ Coverage 72.51% 72.58% +0.07%
- Complexity 67089 67129 +40
============================================
Files 5478 5478
Lines 310036 310039 +3
Branches 45072 45074 +2
============================================
+ Hits 224809 225048 +239
+ Misses 66892 66614 -278
- Partials 18335 18377 +42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jainankitk
approved these changes
Apr 24, 2025
prudhvigodithi
pushed a commit
to prudhvigodithi/OpenSearch
that referenced
this pull request
May 6, 2025
…ject#17978) (opensearch-project#18077) * Enable concurrent_segment_search auto mode by default * Make Default Slice count to 1 for Non-Concurrent Path * Add tolerance to matrix_stats agg correlation value assertion The correlation metric could be different for different document distribution across shards, or slices. slice1(doc1,doc2), slice2(doc3,doc4,doc5) could give different correlation from slice1(doc1,doc2,doc3), slice2(doc4,doc5) The tolerance followed here is 0.000000000000001 --------- Signed-off-by: Vikasht34 <[email protected]> Signed-off-by: bowenlan-amzn <[email protected]> Co-authored-by: Vikasht34 <[email protected]> Signed-off-by: Prudhvi Godithi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport #17978
Related Issues
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.