Skip to content

Conversation

@rayshrey
Copy link
Contributor

@rayshrey rayshrey commented Apr 17, 2025

Description

Adds CompositeDirectoryFactory and makes it pluggable so that plugins can utilize this and implement their own composite directory factory.

Related Issues

Resolves #[17982]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

❌ Gradle check result for 28db81c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@rayshrey rayshrey force-pushed the composite-directory-factory branch from 28db81c to a3659ed Compare April 17, 2025 13:27
@github-actions
Copy link
Contributor

❌ Gradle check result for a3659ed: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@rayshrey rayshrey force-pushed the composite-directory-factory branch from f6cb337 to cf76756 Compare April 18, 2025 09:17
@github-actions
Copy link
Contributor

❌ Gradle check result for cf76756: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@rayshrey rayshrey force-pushed the composite-directory-factory branch from cf76756 to 5e356c0 Compare April 18, 2025 09:53
@github-actions
Copy link
Contributor

❌ Gradle check result for 5e356c0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@rayshrey rayshrey force-pushed the composite-directory-factory branch from 5e356c0 to 158155c Compare April 18, 2025 10:42
@github-actions
Copy link
Contributor

❕ Gradle check result for 158155c: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov
Copy link

codecov bot commented Apr 18, 2025

Codecov Report

Attention: Patch coverage is 77.77778% with 8 lines in your changes missing coverage. Please review.

Project coverage is 72.51%. Comparing base (6ce0628) to head (73d7ae3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
server/src/main/java/org/opensearch/node/Node.java 69.23% 4 Missing ⚠️
...rc/main/java/org/opensearch/index/IndexModule.java 76.92% 1 Missing and 2 partials ⚠️
...c/main/java/org/opensearch/index/IndexService.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17988      +/-   ##
============================================
- Coverage     72.61%   72.51%   -0.11%     
+ Complexity    67203    67143      -60     
============================================
  Files          5473     5474       +1     
  Lines        310145   310178      +33     
  Branches      45064    45066       +2     
============================================
- Hits         225225   224925     -300     
- Misses        66576    66877     +301     
- Partials      18344    18376      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link
Contributor

❌ Gradle check result for 6b5e93a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❕ Gradle check result for 47c5504: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link
Contributor

@gbbafna gbbafna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add changelog as well .

@rayshrey rayshrey force-pushed the composite-directory-factory branch from bee560a to 8460f19 Compare April 24, 2025 13:00
@github-actions
Copy link
Contributor

❕ Gradle check result for 8460f19: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@rayshrey rayshrey force-pushed the composite-directory-factory branch from 069bbbb to c5ad429 Compare April 24, 2025 15:26
@github-actions
Copy link
Contributor

❕ Gradle check result for c5ad429: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@rayshrey rayshrey force-pushed the composite-directory-factory branch from c5ad429 to 03aecdc Compare April 25, 2025 06:24
@github-actions
Copy link
Contributor

❌ Gradle check result for a5f0daf: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@rayshrey rayshrey force-pushed the composite-directory-factory branch 2 times, most recently from 3ee2b39 to 012b35d Compare April 25, 2025 08:23
@github-actions
Copy link
Contributor

❌ Gradle check result for 012b35d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Shreyansh Ray <[email protected]>
@rayshrey rayshrey force-pushed the composite-directory-factory branch from 012b35d to 73d7ae3 Compare April 25, 2025 09:27
@github-actions
Copy link
Contributor

✅ Gradle check result for 73d7ae3: SUCCESS

@gbbafna gbbafna merged commit d744b40 into opensearch-project:main Apr 25, 2025
31 checks passed
rayshrey added a commit to rayshrey/OpenSearch that referenced this pull request Jun 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants