Skip to content

Conversation

@kumargu
Copy link
Contributor

@kumargu kumargu commented Apr 8, 2025

This PR adds a cache of protection domain mapped to a Permission collection. Such a caching is useful to fasten the implies call (from socket and file interceptor) to avoid re-evaluation of permissions in every call.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@kumargu
Copy link
Contributor Author

kumargu commented Apr 8, 2025

cc @andrross @cwperks @reta

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

❌ Gradle check result for 8f36359: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Member

@andrross andrross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The caching logic looks good in general. My comments can be addressed as a follow up.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

❌ Gradle check result for 8f36359: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@kumargu kumargu force-pushed the protection_domain_caching branch 2 times, most recently from e40d2ea to b911f75 Compare April 8, 2025 17:46
@kumargu kumargu force-pushed the protection_domain_caching branch from b911f75 to dbf0d1b Compare April 8, 2025 17:48
@kumargu
Copy link
Contributor Author

kumargu commented Apr 8, 2025

sorry, @andrross could you please review again. i had accidentally removed some comments (added them back).

@kumargu kumargu force-pushed the protection_domain_caching branch from dbf0d1b to 1ce17b6 Compare April 8, 2025 17:54
@kumargu kumargu force-pushed the protection_domain_caching branch from 1ce17b6 to 4ca537f Compare April 8, 2025 17:59
@kumargu kumargu force-pushed the protection_domain_caching branch from 4ca537f to da3fb2d Compare April 8, 2025 18:00
@github-actions
Copy link
Contributor

github-actions bot commented Apr 8, 2025

❕ Gradle check result for da3fb2d: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 72.37%. Comparing base (c91cdcb) to head (da3fb2d).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...va/org/opensearch/secure_sm/policy/PolicyFile.java 0.00% 15 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #17832      +/-   ##
============================================
- Coverage     72.46%   72.37%   -0.09%     
+ Complexity    66502    66449      -53     
============================================
  Files          5408     5408              
  Lines        308080   308157      +77     
  Branches      44720    44735      +15     
============================================
- Hits         223239   223027     -212     
- Misses        66536    66864     +328     
+ Partials      18305    18266      -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andrross andrross merged commit 01e6ed4 into opensearch-project:main Apr 8, 2025
31 of 32 checks passed
@kumargu kumargu deleted the protection_domain_caching branch April 8, 2025 19:47
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
Harsh-87 pushed a commit to Harsh-87/OpenSearch that referenced this pull request May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants