-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[Java Agent] Implement protection domain caching #17832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java Agent] Implement protection domain caching #17832
Conversation
libs/agent-sm/agent-policy/src/main/java/org/opensearch/secure_sm/policy/PolicyFile.java
Outdated
Show resolved
Hide resolved
|
❌ Gradle check result for 8f36359: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
andrross
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The caching logic looks good in general. My comments can be addressed as a follow up.
libs/agent-sm/agent-policy/src/main/java/org/opensearch/secure_sm/policy/PolicyFile.java
Outdated
Show resolved
Hide resolved
libs/agent-sm/agent-policy/src/main/java/org/opensearch/secure_sm/policy/PolicyFile.java
Outdated
Show resolved
Hide resolved
|
❌ Gradle check result for 8f36359: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
e40d2ea to
b911f75
Compare
b911f75 to
dbf0d1b
Compare
|
sorry, @andrross could you please review again. i had accidentally removed some comments (added them back). |
dbf0d1b to
1ce17b6
Compare
Signed-off-by: Gulshan Kumar <[email protected]>
1ce17b6 to
4ca537f
Compare
Signed-off-by: Gulshan Kumar <[email protected]>
4ca537f to
da3fb2d
Compare
|
❕ Gradle check result for da3fb2d: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17832 +/- ##
============================================
- Coverage 72.46% 72.37% -0.09%
+ Complexity 66502 66449 -53
============================================
Files 5408 5408
Lines 308080 308157 +77
Branches 44720 44735 +15
============================================
- Hits 223239 223027 -212
- Misses 66536 66864 +328
+ Partials 18305 18266 -39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…17832) Signed-off-by: Gulshan Kumar <[email protected]> Signed-off-by: Harsh Kothari <[email protected]>
…17832) Signed-off-by: Gulshan Kumar <[email protected]> Signed-off-by: Harsh Kothari <[email protected]>
This PR adds a cache of protection domain mapped to a Permission collection. Such a caching is useful to fasten the
impliescall (from socket and file interceptor) to avoid re-evaluation of permissions in every call.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.