Introduce 512 byte limit to search and ingest pipeline IDs #17786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owaiskazi19
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
ashking94,
bugmakerrrrrr,
cwperks,
dblock,
dbwiddis,
gbbafna,
jainankitk,
jed326,
kotwanikunal,
linuxpi,
mch2,
msfroh,
nknize,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja and
sohami
as code owners
github-actions
bot
added
bug
owaiskazi19
force-pushed
the
pipeline-validation
branch
from
8da6a2c to
ee316d0
Compare
owaiskazi19
commented
Apr 3, 2025
Signed-off-by: Owais <[email protected]>
owaiskazi19
force-pushed
the
pipeline-validation
branch
from
ee316d0 to
5ea651c
Compare
andrross
reviewed
Apr 4, 2025
Contributor
|
❌ Gradle check result for 24d500f: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Owais <[email protected]>
owaiskazi19
force-pushed
the
pipeline-validation
branch
from
24d500f to
470e4ee
Compare
owaiskazi19
changed the title
Contributor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17786 +/- ##
============================================
+ Coverage 72.32% 72.37% +0.05%
- Complexity 66005 66052 +47
============================================
Files 5356 5358 +2
Lines 306446 306499 +53
Branches 44395 44404 +9
============================================
+ Hits 221634 221830 +196
+ Misses 66660 66478 -182
- Partials 18152 18191 +39 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrross
approved these changes
Apr 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve validation for ingest and search pipeline id length to 20.
Related Issues
Resolves #17766
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.