Fix missing bucket in terms aggregation with missing value

[kkewwei]

Signed-off-by: kkewwei [email protected]
Signed-off-by: kkewwei [email protected]

Fix missing bucket in terms aggregation with missing value

Description

[Describe what this change achieves]

Related Issues

Resolves #17391

Check List

• Functionality includes testing.
• API changes companion pull request created, if applicable.
• Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[andrross]

Thanks @kkewwei!

Are there other places where the logical change in GlobalOrdinalsStringTermsAggregator might cause problems?

[github-actions]

❌ Gradle check result for 317a1d2: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[kkewwei]

Thanks @kkewwei!

Are there other places where the logical change in GlobalOrdinalsStringTermsAggregator might cause problems?

@andrross Thank you for your reply.

We just change three same code in 7c46f8f, I think it will not cause other problems.

[github-actions]

❌ Gradle check result for a845d85: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

[github-actions]

✅ Gradle check result for a845d85: SUCCESS

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.40%. Comparing base (abe2333) to head (a845d85).
Report is 3 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #17418      +/-   ##
============================================
- Coverage     72.41%   72.40%   -0.02%     
+ Complexity    65667    65647      -20     
============================================
  Files          5303     5303              
  Lines        304781   304793      +12     
  Branches      44201    44202       +1     
============================================
- Hits         220709   220672      -37     
- Misses        65959    66043      +84     
+ Partials      18113    18078      -35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[noCharger]

Can we add another case where field is in text but has two words?

[andrross]

Can we add another case where field is in text but has two words?

@noCharger The test that was added here failed for the text case without the fix so I think it probably gives sufficient coverage.