Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Removing String format in RemoteStoreMigrationAllocationDecider #15105

Closed
RS146BIJAY opened this issue Aug 5, 2024 · 0 comments
Closed
Labels
bug Something isn't working Indexing:Replication Issues and PRs related to core replication framework eg segrep untriaged

Comments

@RS146BIJAY
Copy link
Contributor

Describe the bug

Description

String.format is a relatively expensive operation for concatenating strings. Inside RemoteStoreMigrationAllocationDecider, the function calls to String.format stands out as the most resource-intensive operation in terms of latency.

Screenshot 2024-06-27 at 7 04 26 PM

Related component

Indexing:Replication

To Reproduce

Create 500k shards on a setup with 1000 data nodes and 3 master nodes.

Expected behavior

Improves the latency of RemoteStoreMigrationAllocationDecider by replacing calls to String.format with more efficient StringBuilder for string concatenation

Additional Details

Plugins
Please list all plugins currently enabled.

Screenshots
If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here.

@RS146BIJAY RS146BIJAY added bug Something isn't working untriaged labels Aug 5, 2024
@github-actions github-actions bot added the Indexing:Replication Issues and PRs related to core replication framework eg segrep label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Indexing:Replication Issues and PRs related to core replication framework eg segrep untriaged
Projects
None yet
Development

No branches or pull requests

1 participant