Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add baseline comparison results to pull requests for performance benchmarks #14826

Closed
Tracked by #14553
rishabh6788 opened this issue Jul 18, 2024 · 2 comments
Closed
Tracked by #14553
Assignees
Labels
benchmarking Issues related to benchmarking or performance. enhancement Enhancement or improvement to existing feature or request Other Performance This is for any performance related enhancements or bugs

Comments

@rishabh6788
Copy link
Contributor

Is your feature request related to a problem? Please describe

Continuing from #14553 creating this issue to track progress on adding feature that will also add baseline performance comparison results on the pull request after benchmark run has completed.

Describe the solution you'd like

opensearch-benchmark provided out of the box compare command that compares the benchmark results between two runs and publishes the results highlighting differences between each operation.
The idea is to extend the existing workflow (#14760) to also add the comparison results on the PR once the performance run has completed for the same PR.

Related component

Other

Describe alternatives you've considered

No response

Additional context

No response

@peternied
Copy link
Member

[Triage - attendees 1 2]
@rishabh6788 Thanks for creating this issue, look forward to seeing a pull request that adds this functionality.

@rishabh6788
Copy link
Contributor Author

All required changes have been merged, the feature is live now.
Apart from getting performance benchmark numbers, the users now will also see baseline comparison results as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarking Issues related to benchmarking or performance. enhancement Enhancement or improvement to existing feature or request Other Performance This is for any performance related enhancements or bugs
Development

No branches or pull requests

2 participants