Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a 4-digit version number everywhere #1093

Open
dblock opened this issue Aug 14, 2021 · 2 comments
Open

Use a 4-digit version number everywhere #1093

dblock opened this issue Aug 14, 2021 · 2 comments
Labels
enhancement Enhancement or improvement to existing feature or request

Comments

@dblock
Copy link
Member

dblock commented Aug 14, 2021

Is your feature request related to a problem? Please describe.

OpenSearch artifacts produced a 3-digit version, e.g. 1.1.0, whereas plugins are 4-digit versions, e.g. 1.1.0.0. This is because in ODFE we incremented the final digit in the oplugin when there was a new plugin versions for the same ODFE version. Then the final digit was reset to 0 when upgrading to a new ODFE version.

This feels unnecessary since we release everything together, and introduces build scripts that have to parse OpenSearch version in bizarre ways, e.g. opensearch-project/anomaly-detection@096a670 or https://github.com/opensearch-project/job-scheduler/blob/main/build.gradle#L89.

Describe the solution you'd like
Move to a 4-digit build number.

@dblock dblock added the enhancement Enhancement or improvement to existing feature or request label Aug 14, 2021
@dblock dblock changed the title Use a 4-digit version Use a 4-digit version number everywhere Aug 14, 2021
@frotsch
Copy link
Contributor

frotsch commented Aug 15, 2021

@dblock
Copy link
Member Author

dblock commented Aug 16, 2021

FYI, we're working on an end-to-end workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement or improvement to existing feature or request
Projects
None yet
Development

No branches or pull requests

2 participants