Skip to content

Commit 9e49930

Browse files
authored
[GRPC] Remove experimental from transport-grpc setting name (#18915)
Signed-off-by: Karen Xu <[email protected]>
1 parent 163c870 commit 9e49930

File tree

5 files changed

+9
-8
lines changed

5 files changed

+9
-8
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
5555
- Making multi rate limiters in repository dynamic [#18069](https://github.com/opensearch-project/OpenSearch/pull/18069)
5656
- Optimize grouping for segment concurrent search by ensuring that documents within each group are as equal as possible ([#18451](https://github.com/opensearch-project/OpenSearch/pull/18451))
5757
- Move transport-grpc from a core plugin to a module ([#18897](https://github.com/opensearch-project/OpenSearch/pull/18897))
58+
- Remove `experimental` designation from transport-grpc settings ([#18915](https://github.com/opensearch-project/OpenSearch/pull/18915))
5859

5960
### Dependencies
6061
- Bump `stefanzweifel/git-auto-commit-action` from 5 to 6 ([#18524](https://github.com/opensearch-project/OpenSearch/pull/18524))

modules/transport-grpc/README.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,15 @@ The `transport-grpc` module initializes a new client/server transport implementi
99
Enable this transport with:
1010

1111
```
12-
setting 'aux.transport.types', '[experimental-transport-grpc]'
13-
setting 'aux.transport.experimental-transport-grpc.port', '9400-9500' //optional
12+
setting 'aux.transport.types', '[transport-grpc]'
13+
setting 'aux.transport.transport-grpc.port', '9400-9500' //optional
1414
```
1515

1616
For the secure transport:
1717

1818
```
19-
setting 'aux.transport.types', '[experimental-secure-transport-grpc]'
20-
setting 'aux.transport.experimental-secure-transport-grpc.port', '9400-9500' //optional
19+
setting 'aux.transport.types', '[secure-transport-grpc]'
20+
setting 'aux.transport.secure-transport-grpc.port', '9400-9500' //optional
2121
```
2222

2323

@@ -76,5 +76,5 @@ setting 'grpc.netty.keepalive_timeout', '1s'
7676
To run OpenSearch with the gRPC transport enabled:
7777

7878
```bash
79-
./gradlew run -Dtests.opensearch.aux.transport.types="[experimental-transport-grpc]"
79+
./gradlew run -Dtests.opensearch.aux.transport.types="[transport-grpc]"
8080
```

modules/transport-grpc/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ opensearchplugin {
1616

1717
testClusters {
1818
integTest {
19-
setting 'aux.transport.types', '[experimental-transport-grpc]'
19+
setting 'aux.transport.types', '[transport-grpc]'
2020
}
2121
}
2222

modules/transport-grpc/src/main/java/org/opensearch/plugin/transport/grpc/Netty4GrpcServerTransport.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ public class Netty4GrpcServerTransport extends AuxTransport {
6262
/**
6363
* Type key for configuring settings of this auxiliary transport.
6464
*/
65-
public static final String GRPC_TRANSPORT_SETTING_KEY = "experimental-transport-grpc";
65+
public static final String GRPC_TRANSPORT_SETTING_KEY = "transport-grpc";
6666

6767
/**
6868
* Port range on which to bind.

modules/transport-grpc/src/main/java/org/opensearch/plugin/transport/grpc/ssl/SecureNetty4GrpcServerTransport.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public class SecureNetty4GrpcServerTransport extends Netty4GrpcServerTransport {
4242
/**
4343
* Type key to select secure transport.
4444
*/
45-
public static final String GRPC_SECURE_TRANSPORT_SETTING_KEY = "experimental-secure-transport-grpc";
45+
public static final String GRPC_SECURE_TRANSPORT_SETTING_KEY = "secure-transport-grpc";
4646

4747
/**
4848
* Distinct port setting required as it depends on transport type key.

0 commit comments

Comments
 (0)