Skip to content

Commit 4c9f2f1

Browse files
author
Tianli Feng
committed
Reserve all methods with 'master' in the names in the package 'org.opensearch.action.support.clustermanager'
Signed-off-by: Tianli Feng <[email protected]>
1 parent d8d0640 commit 4c9f2f1

File tree

4 files changed

+10
-3
lines changed

4 files changed

+10
-3
lines changed

server/src/main/java/org/opensearch/action/support/clustermanager/ClusterManagerNodeOperationRequestBuilder.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,8 @@ public final RequestBuilder setClusterManagerNodeTimeout(TimeValue timeout) {
6565

6666
/**
6767
* Sets the cluster-manager node timeout in case the cluster-manager has not yet been discovered.
68+
*
69+
* @deprecated As of 2.1, because supporting inclusive language, replaced by {@link #setClusterManagerNodeTimeout(TimeValue)}
6870
*/
6971
@SuppressWarnings("unchecked")
7072
@Deprecated
@@ -83,6 +85,8 @@ public final RequestBuilder setClusterManagerNodeTimeout(String timeout) {
8385

8486
/**
8587
* Sets the cluster-manager node timeout in case the cluster-manager has not yet been discovered.
88+
*
89+
* @deprecated As of 2.1, because supporting inclusive language, replaced by {@link #setClusterManagerNodeTimeout(String)}
8690
*/
8791
@SuppressWarnings("unchecked")
8892
@Deprecated

server/src/main/java/org/opensearch/action/support/clustermanager/ClusterManagerNodeRequest.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,11 +48,13 @@ public abstract class ClusterManagerNodeRequest<Request extends ClusterManagerNo
4848

4949
public static final TimeValue DEFAULT_CLUSTER_MANAGER_NODE_TIMEOUT = TimeValue.timeValueSeconds(30);
5050

51+
/** @deprecated As of 2.1, because supporting inclusive language, replaced by {@link #DEFAULT_CLUSTER_MANAGER_NODE_TIMEOUT} */
5152
@Deprecated
5253
public static final TimeValue DEFAULT_MASTER_NODE_TIMEOUT = DEFAULT_CLUSTER_MANAGER_NODE_TIMEOUT;
5354

5455
protected TimeValue clusterManagerNodeTimeout = DEFAULT_CLUSTER_MANAGER_NODE_TIMEOUT;
5556

57+
/** @deprecated As of 2.1, because supporting inclusive language, replaced by {@link #clusterManagerNodeTimeout} */
5658
@Deprecated
5759
protected TimeValue masterNodeTimeout = clusterManagerNodeTimeout;
5860

@@ -80,6 +82,8 @@ public final Request clusterManagerNodeTimeout(TimeValue timeout) {
8082

8183
/**
8284
* A timeout value in case the cluster-manager has not been discovered yet or disconnected.
85+
*
86+
* @deprecated As of 2.1, because supporting inclusive language, replaced by {@link #clusterManagerNodeTimeout(TimeValue)}
8387
*/
8488
@SuppressWarnings("unchecked")
8589
@Deprecated
@@ -98,6 +102,8 @@ public final Request clusterManagerNodeTimeout(String timeout) {
98102

99103
/**
100104
* A timeout value in case the cluster-manager has not been discovered yet or disconnected.
105+
*
106+
* @deprecated As of 2.1, because supporting inclusive language, replaced by {@link #clusterManagerNodeTimeout(String)}
101107
*/
102108
@Deprecated
103109
public final Request masterNodeTimeout(String timeout) {
@@ -108,7 +114,6 @@ public final TimeValue clusterManagerNodeTimeout() {
108114
return this.clusterManagerNodeTimeout;
109115
}
110116

111-
// Preserve the method so that classes implements AcknowledgedRequest don't need to override it for backwards compatibility.
112117
/** @deprecated As of 2.1, because supporting inclusive language, replaced by {@link #clusterManagerNodeTimeout()} */
113118
@Deprecated
114119
public final TimeValue masterNodeTimeout() {

server/src/main/java/org/opensearch/action/support/master/MasterNodeOperationRequestBuilder.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,5 +54,4 @@ public abstract class MasterNodeOperationRequestBuilder<
5454
protected MasterNodeOperationRequestBuilder(OpenSearchClient client, ActionType<Response> action, Request request) {
5555
super(client, action, request);
5656
}
57-
5857
}

server/src/main/java/org/opensearch/action/support/master/MasterNodeRequest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,5 +49,4 @@ public abstract class MasterNodeRequest<Request extends MasterNodeRequest<Reques
4949
protected MasterNodeRequest(StreamInput in) throws IOException {
5050
super(in);
5151
}
52-
5352
}

0 commit comments

Comments
 (0)