Poll for results from frontend for async search #8481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amardeepsingh Siglani <[email protected]>
amsiglan
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
AMoo-Miki
reviewed
Oct 4, 2024
AMoo-Miki
previously approved these changes
Oct 4, 2024
ashwin-pc
requested changes
Oct 4, 2024
|
For reference |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8481 +/- ##
==========================================
- Coverage 60.93% 60.91% -0.02%
==========================================
Files 3760 3761 +1
Lines 89301 89325 +24
Branches 13969 13977 +8
==========================================
+ Hits 54412 54413 +1
- Misses 31493 31516 +23
Partials 3396 3396
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Amardeepsingh Siglani <[email protected]>
|
Fixed the async sql strategy and also the issue that we see |
ashwin-pc
approved these changes
Oct 7, 2024
src/plugins/query_enhancements/server/search/sql_async_search_strategy.ts
Show resolved
Hide resolved
AMoo-Miki
reviewed
Oct 7, 2024
src/plugins/query_enhancements/server/search/sql_async_search_strategy.ts
Show resolved
Hide resolved
AMoo-Miki
approved these changes
Oct 7, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 7, 2024
* poll for results from frontend for async search Signed-off-by: Amardeepsingh Siglani <[email protected]> * Changeset file for PR #8481 created/updated * fixed async sql strategy; added elapsed time to results Signed-off-by: Amardeepsingh Siglani <[email protected]> * removed unwanted toast notifications Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 58e1645) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AMoo-Miki
pushed a commit
that referenced
this pull request
Oct 7, 2024
* poll for results from frontend for async search * Changeset file for PR #8481 created/updated * fixed async sql strategy; added elapsed time to results * removed unwanted toast notifications --------- (cherry picked from commit 58e1645) Signed-off-by: Amardeepsingh Siglani <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
joshuali925
reviewed
Oct 9, 2024
| takeWhile((response: FetchStatusResponse) => { | ||
| const status = response?.status?.toUpperCase(); | ||
| return status !== 'SUCCESS' && status !== 'FAILED'; | ||
| }, true), |
There was a problem hiding this comment.
this takeWhile seems unnecessary? since it's anyways take(1) if a response passes through filter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently for async search we depend on the search strategy to start the query and poll for results and resolve once the query completes/fails but since can to the order of 1 to 2 min, the frontend will timeout. This PR adds logic in frontend to poll for the results once the query is started.
The search strategy's search method will be invoked with the query id when polling for results, else it should start search for the given query.
Testing the changes
Tested using local setup and neo app
Changelog
Check List
yarn test:jestyarn test:jest_integration