[Workspace] fix breadcrumbs for workspace #8303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hailong Cui <[email protected]>
opensearch-changeset-bot bot
added a commit
to Hailong-am/OpenSearch-Dashboards
that referenced
this pull request
Sep 23, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8303 +/- ##
==========================================
- Coverage 60.92% 60.92% -0.01%
==========================================
Files 3750 3751 +1
Lines 89054 89044 -10
Branches 13910 13905 -5
==========================================
- Hits 54257 54249 -8
+ Misses 31433 31429 -4
- Partials 3364 3366 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fix bootstrap error Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]> fix bootstrap error Signed-off-by: Hailong Cui <[email protected]>
Hailong-am
force-pushed
the
breadcrumbs
branch
from
28ebd96 to
b1db16f
Compare
Hailong-am
changed the title
Signed-off-by: Hailong Cui <[email protected]>
Hailong-am
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric and
LDrago27
as code owners
|
link checker failure will handled by #8309 |
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
Signed-off-by: Hailong Cui <[email protected]>
SuZhou-Joe
previously approved these changes
Sep 29, 2024
ruanyl
previously approved these changes
Sep 29, 2024
src/plugins/home/public/application/components/usecase_overview/search_use_case_app.tsx
Show resolved
Hide resolved
src/plugins/workspace/public/components/workspace_name/workspace_name_with_icon.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Hailong Cui <[email protected]>
ruanyl
approved these changes
Sep 30, 2024
SuZhou-Joe
approved these changes
Sep 30, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 30, 2024
* update breadcrumbs Signed-off-by: Hailong Cui <[email protected]> * Changeset file for PR #8303 created/updated fix bootstrap error Signed-off-by: Hailong Cui <[email protected]> * make the workspace name not repsonsive that will not break into two rows Signed-off-by: Hailong Cui <[email protected]> fix bootstrap error Signed-off-by: Hailong Cui <[email protected]> * fix failed unit test Signed-off-by: Hailong Cui <[email protected]> * link check Signed-off-by: Hailong Cui <[email protected]> * set overview page title to include itself use case name in all use case Signed-off-by: Hailong Cui <[email protected]> * hideTrailingSeparator for breadcrumbs in recently popover Signed-off-by: Hailong Cui <[email protected]> * update breadcrumbs for search overview Signed-off-by: Hailong Cui <[email protected]> * update overview page id Signed-off-by: Hailong Cui <[email protected]> * Address review comments Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 9369f37) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl
pushed a commit
that referenced
this pull request
Sep 30, 2024
* update breadcrumbs * Changeset file for PR #8303 created/updated fix bootstrap error * make the workspace name not repsonsive that will not break into two rows fix bootstrap error * fix failed unit test * link check * set overview page title to include itself use case name in all use case * hideTrailingSeparator for breadcrumbs in recently popover * update breadcrumbs for search overview * update overview page id * Address review comments --------- (cherry picked from commit 9369f37) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Oct 3, 2024
…pensearch-project#8384) * update breadcrumbs * Changeset file for PR opensearch-project#8303 created/updated fix bootstrap error * make the workspace name not repsonsive that will not break into two rows fix bootstrap error * fix failed unit test * link check * set overview page title to include itself use case name in all use case * hideTrailingSeparator for breadcrumbs in recently popover * update breadcrumbs for search overview * update overview page id * Address review comments --------- (cherry picked from commit 9369f37) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
This was referenced Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Homefrom breadcrumbsOverviewIssues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration