-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace]Disable "Save changes" button on character limit exceeded #8153
Merged
ruanyl
merged 7 commits into
opensearch-project:main
from
wanglam:feat-workspace-detail-save-changes-button-disabled
Sep 29, 2024
Merged
[Workspace]Disable "Save changes" button on character limit exceeded #8153
ruanyl
merged 7 commits into
opensearch-project:main
from
wanglam:feat-workspace-detail-save-changes-button-disabled
Sep 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lin Wang <[email protected]>
wanglam
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
September 12, 2024 05:52
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8153 +/- ##
==========================================
- Coverage 60.92% 60.92% -0.01%
==========================================
Files 3749 3749
Lines 89021 89023 +2
Branches 13899 13901 +2
==========================================
Hits 54236 54236
- Misses 31423 31424 +1
- Partials 3362 3363 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
SuZhou-Joe
previously approved these changes
Sep 20, 2024
ruanyl
approved these changes
Sep 29, 2024
SuZhou-Joe
approved these changes
Sep 29, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 29, 2024
…8153) * Disable "Save changes" button on character limit exceeded Signed-off-by: Lin Wang <[email protected]> * Changeset file for PR #8153 created/updated * Add more test case for empty name and description Signed-off-by: Lin Wang <[email protected]> --------- Signed-off-by: Lin Wang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 09bd013) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Sep 30, 2024
…8153) (#8374) * Disable "Save changes" button on character limit exceeded * Changeset file for PR #8153 created/updated * Add more test case for empty name and description --------- (cherry picked from commit 09bd013) Signed-off-by: Lin Wang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
to SuZhou-Joe/OpenSearch-Dashboards
that referenced
this pull request
Oct 3, 2024
…pensearch-project#8153) (opensearch-project#8374) * Disable "Save changes" button on character limit exceeded * Changeset file for PR opensearch-project#8153 created/updated * Add more test case for empty name and description --------- (cherry picked from commit 09bd013) Signed-off-by: Lin Wang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for disable the 'Save Changes' button when the number of characters in the name or description exceeds the maximum limit.
Issues Resolved
#8154
Screenshot
Testing the changes
yarn osd bootstrap --single-version ignore
config/opensearch_dashboards.yml
yarn start --no-base-path
Changelog
Check List
yarn test:jest
yarn test:jest_integration