Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Look&Feel] Replace browser tooltip usage with OUI tooltip #7231

Merged
merged 3 commits into from
Jul 22, 2024

Conversation

danieldong51
Copy link
Contributor

@danieldong51 danieldong51 commented Jul 12, 2024

Description

Changes instances of browser tooltip usage with OUI tooltip

Screenshot

Replacing existing browser tooltip usage

Scope Before (v7Light) After (v7Light) Before (v8dark) After (v8dark)
Header: Menu Icon Menu v7 Light Before Menu v7 Light Post Menu v8 Dark Before Menu v8 Dark Post
Header: Home Icon Home Icon v7 Light Before Home Icon v7 Light Post Home Icon v8 Dark Before Home Icon v8 Dark Post
Header: Dev Tools (Future Nav) Dev Tools v7 Light Before Dev Tools v7 Light Post Dev Tools v8 Dark Before Dev Tools v8 Dark Post
Header: Help Icon Help v7 Light Before Help v7 Light Post Help v8 Dark Before Help v8 Dark Post
Header: Appearance Appearance v7 Light Before Appearance v7 Light Post Appearance v8 Dark Before Appearance v8 Dark Post
Data: Change Filters Change Filters v7 Light Before Change Filters v7 Light Post Change Filters v8 Dark Before Change Filters v8 Dark Post
Data: Saved Queries Saved Queries v7 Light Before Saved Queries v7 Light Post Saved Queries v8 Dark Before Saved Queries v8 Dark Post
Discover: Field Discover Field v7 Light Before Discover Field v7 Light Post Discover Field v8 Dark Before Discover Field v8 Dark Post
Visualization: Toggle Legend Toggle Legend v7 Light Before Toggle Legend v7 Light Post Toggle Legend v8 Dark Before Toggle Legend v8 Dark Post

New tooltip usage

Added tooltip for plusInCircle and minusInCircle icons to match tooltip usage on the rest of Discover page.

Scope Before (v7Light) After (v7Light) Before (v8dark) After (v8dark)
Discover: Filter Values Discover Filter v7 Light Before Discover Filter v7 Light Post Discover Filter v8 Dark Before Discover Filter v8 Dark Post

Changelog

  • refactor: [Look&Feel] Replace browser tooltip usage with OUI tooltip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

1 similar comment
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.75%. Comparing base (46afb96) to head (7950054).
Report is 289 commits behind head on main.

Files with missing lines Patch % Lines
src/core/public/chrome/ui/header/header.tsx 0.00% 1 Missing ⚠️
...dvanced_settings/public/header_user_theme_menu.tsx 0.00% 1 Missing ⚠️
.../application/components/sidebar/discover_field.tsx 50.00% 0 Missing and 1 partial ⚠️
...ation/components/sidebar/discover_field_bucket.tsx 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7231      +/-   ##
==========================================
+ Coverage   67.70%   67.75%   +0.04%     
==========================================
  Files        3521     3521              
  Lines       69777    69781       +4     
  Branches    11390    11390              
==========================================
+ Hits        47244    47277      +33     
+ Misses      19732    19694      -38     
- Partials     2801     2810       +9     
Flag Coverage Δ
Linux_1 33.15% <20.00%> (+<0.01%) ⬆️
Linux_2 55.50% <75.00%> (+0.04%) ⬆️
Linux_3 43.31% <46.15%> (?)
Linux_4 34.81% <0.00%> (ø)
Windows_1 33.17% <20.00%> (+<0.01%) ⬆️
Windows_2 55.45% <75.00%> (+0.04%) ⬆️
Windows_3 43.31% <46.15%> (+0.05%) ⬆️
Windows_4 34.81% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

8 similar comments
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

opensearch-changeset-bot bot added a commit to danieldong51/OpenSearch-Dashboards that referenced this pull request Jul 15, 2024
danieldong51 pushed a commit to danieldong51/OpenSearch-Dashboards that referenced this pull request Jul 17, 2024
@danieldong51 danieldong51 marked this pull request as ready for review July 17, 2024 17:53
danieldong51 pushed a commit to danieldong51/OpenSearch-Dashboards that referenced this pull request Jul 21, 2024
danieldong51 pushed a commit to danieldong51/OpenSearch-Dashboards that referenced this pull request Jul 21, 2024
zhongnansu
zhongnansu previously approved these changes Jul 21, 2024
virajsanghvi
virajsanghvi previously approved these changes Jul 22, 2024
Copy link
Collaborator

@virajsanghvi virajsanghvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, trying to rerun failed cypress test to see if flakey

@danieldong51 danieldong51 dismissed stale reviews from virajsanghvi and zhongnansu via 1959ef8 July 22, 2024 06:16
Copy link
Collaborator

@virajsanghvi virajsanghvi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving as failing cypress is flakey/non-deterministic

@zhongnansu zhongnansu merged commit a9801a2 into opensearch-project:main Jul 22, 2024
65 of 67 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7231-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a9801a2c31858b84f77e51eab2381ee9744989d9
# Push it to GitHub
git push --set-upstream origin backport/backport-7231-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7231-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.16 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.16 2.16
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.16
# Create a new branch
git switch --create backport/backport-7231-to-2.16
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a9801a2c31858b84f77e51eab2381ee9744989d9
# Push it to GitHub
git push --set-upstream origin backport/backport-7231-to-2.16
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.16

Then, create a pull request where the base branch is 2.16 and the compare/head branch is backport/backport-7231-to-2.16.

@SuZhou-Joe
Copy link
Member

SuZhou-Joe commented Jul 25, 2024

Seems like this PR introduces a bug: #7483.

@AMoo-Miki
Copy link
Collaborator

Spoke to @SuZhou-Joe: As a result of the bug, this PR was reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants