-
Notifications
You must be signed in to change notification settings - Fork 906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI change for datasource view picker to enable selectable #6497
Conversation
ℹ️ Manual Changeset Creation ReminderPlease ensure manual commit for changeset file 6497.yml under folder changelogs/fragments to complete this PR. If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link. For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool. |
❌ Changeset File Not Added YetPlease ensure manual commit for changeset file 6497.yml under folder changelogs/fragments to complete this PR. File still missing. |
4973e7b
to
cf0f3a1
Compare
❌ Changeset File Not Added YetPlease ensure manual commit for changeset file 6497.yml under folder changelogs/fragments to complete this PR. File still missing. |
1 similar comment
❌ Changeset File Not Added YetPlease ensure manual commit for changeset file 6497.yml under folder changelogs/fragments to complete this PR. File still missing. |
}); | ||
if (this.props.onSelectedDataSources) { | ||
this.props.onSelectedDataSources([]); | ||
} | ||
handleDataSourceFetchError(this.onError.bind(this), this.props.notifications!); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we see if we can remove line 118-124 and use the handleDataSourceFetchError instead?
b11dd29
to
912208c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6497 +/- ##
==========================================
+ Coverage 32.93% 34.95% +2.01%
==========================================
Files 2260 1916 -344
Lines 45769 37077 -8692
Branches 7200 6824 -376
==========================================
- Hits 15075 12961 -2114
+ Misses 29984 23256 -6728
- Partials 710 860 +150
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, except 1 typo
src/plugins/data_source_management/public/components/data_source_view/data_source_view.tsx
Outdated
Show resolved
Hide resolved
src/plugins/data_source_management/public/components/data_source_view/data_source_view.test.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Yuanqi(Ella) Zhu <[email protected]>
8397e97
to
599c531
Compare
Signed-off-by: Yuanqi(Ella) Zhu <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6497-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 b6978f235fc6004c679420e6eb3b801db1d602a1
# Push it to GitHub
git push --set-upstream origin backport/backport-6497-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
* UI change for data source view to enable selectable Signed-off-by: Yuanqi(Ella) Zhu <[email protected]> * Fix typo and rebase Signed-off-by: Yuanqi(Ella) Zhu <[email protected]> --------- Signed-off-by: Yuanqi(Ella) Zhu <[email protected]> (cherry picked from commit b6978f2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
…6538) * UI change for data source view to enable selectable Signed-off-by: Yuanqi(Ella) Zhu <[email protected]> * Fix typo and rebase Signed-off-by: Yuanqi(Ella) Zhu <[email protected]> --------- Signed-off-by: Yuanqi(Ella) Zhu <[email protected]> (cherry picked from commit b6978f2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Description
UI change for datasource view picker to enable selectable #6497
Issues Resolved
Screenshot
Toast: Data source is not available
Toast: Failed to fetch data source
Show local cluster
Testing the changes
4.activeOption={[{id: 'valid id'}]}
show selected cluster
show selected cluster with label name
activeOption: [{ id: '6304d1d0-f826-11ee-ab60-439c91fde80b', label:'show label' }],
dataSourceFilter: (ds) => {return ds.id != '6304d1d0-f826-11ee-ab60-439c91fde80b'},
toast: datasource is not available
Changelog
Check List
yarn test:jest
yarn test:jest_integration