Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vis Builder] Rename wizard to visBuilder in class name, type name and function name #2639

Conversation

abbyhu2000
Copy link
Member

Reame wizard to visBuilder

Signed-off-by: abbyhu2000 [email protected]

Description

Rename wizard to visBuilder in class name, type name and function name

Issues Resolved

resolves part of #1706

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@abbyhu2000 abbyhu2000 self-assigned this Oct 20, 2022
@abbyhu2000 abbyhu2000 added vis builder v2.4.0 'Issues and PRs related to version v2.4.0' backport 2.x labels Oct 20, 2022
@abbyhu2000 abbyhu2000 force-pushed the rename_wizard_in_classname_functionname branch from a48667c to 71e5b0c Compare October 20, 2022 21:10
@abbyhu2000 abbyhu2000 marked this pull request as ready for review October 20, 2022 21:27
@abbyhu2000 abbyhu2000 requested a review from a team as a code owner October 20, 2022 21:27
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@8d5e504). Click here to learn what that means.
The diff coverage is 34.66%.

❗ Current head a48667c differs from pull request most recent head 71e5b0c. Consider uploading reports for the commit 71e5b0c to get more accurate results

@@           Coverage Diff           @@
##             main    #2639   +/-   ##
=======================================
  Coverage        ?   66.81%           
=======================================
  Files           ?     3207           
  Lines           ?    61149           
  Branches        ?     9316           
=======================================
  Hits            ?    40858           
  Misses          ?    18060           
  Partials        ?     2231           
Impacted Files Coverage Δ
src/plugins/vis_builder/common/index.ts 100.00% <ø> (ø)
...c/application/components/data_tab/field_search.tsx 0.00% <ø> (ø)
...pplication/components/data_tab/secondary_panel.tsx 2.32% <0.00%> (ø)
...pplication/components/data_tab/use/use_dropbox.tsx 5.63% <0.00%> (ø)
...uilder/public/application/components/right_nav.tsx 13.33% <0.00%> (ø)
..._builder/public/application/components/top_nav.tsx 5.00% <0.00%> (ø)
...uilder/public/application/components/workspace.tsx 4.00% <0.00%> (ø)
...plication/utils/state_management/metadata_slice.ts 45.45% <ø> (ø)
...blic/application/utils/state_management/preload.ts 20.00% <ø> (ø)
...tion/utils/state_management/visualization_slice.ts 17.14% <ø> (ø)
... and 21 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@@ -26,6 +26,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
* [Vis Builder] Change wizard to vis_builder in file names and paths ([#2587](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2587))
* [Multi DataSource] Address UX comments on Data source list and create page ([#2625](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2625))
* [Vis Builder] Rename wizard to visBuilder in i18n id and formatted message id ([#2635](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2635))
* [Vis Builder] Rename wizard to visBuilder in class name, type name and function name ([#2639](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/2639))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need to consolidate the changelog for all the renaming stuff. but not for this PR though.

@abbyhu2000 abbyhu2000 merged commit 74fd39f into opensearch-project:main Oct 21, 2022
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2639-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 74fd39fdab816dd16014acdc88d9fd649acbcf7f
# Push it to GitHub
git push --set-upstream origin backport/backport-2639-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2639-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.4 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.4 2.4
# Navigate to the new working tree
pushd ../.worktrees/backport-2.4
# Create a new branch
git switch --create backport-2639-to-2.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 74fd39fdab816dd16014acdc88d9fd649acbcf7f
# Push it to GitHub
git push --set-upstream origin backport-2639-to-2.4
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.4

Then, create a pull request where the base branch is 2.4 and the compare/head branch is backport-2639-to-2.4.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 2, 2022
#2639)

Rname wizard to visBuilder

Signed-off-by: abbyhu2000 <[email protected]>

Signed-off-by: abbyhu2000 <[email protected]>
(cherry picked from commit 74fd39f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
AMoo-Miki pushed a commit that referenced this pull request Nov 3, 2022
#2639) (#2748)

Rname wizard to visBuilder

Signed-off-by: abbyhu2000 <[email protected]>

Signed-off-by: abbyhu2000 <[email protected]>
(cherry picked from commit 74fd39f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@AMoo-Miki
Copy link
Collaborator

AMoo-Miki commented Nov 3, 2022

Will try to backport 2.4 from the 2.x PR.

Will do manually.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.4 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.4 2.4
# Navigate to the new working tree
pushd ../.worktrees/backport-2.4
# Create a new branch
git switch --create backport-2639-to-2.4
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 74fd39fdab816dd16014acdc88d9fd649acbcf7f
# Push it to GitHub
git push --set-upstream origin backport-2639-to-2.4
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.4

Then, create a pull request where the base branch is 2.4 and the compare/head branch is backport-2639-to-2.4.

abbyhu2000 added a commit to abbyhu2000/OpenSearch-Dashboards that referenced this pull request Nov 3, 2022
opensearch-project#2639)

Rname wizard to visBuilder

Signed-off-by: abbyhu2000 <[email protected]>

Signed-off-by: abbyhu2000 <[email protected]>
ananzh pushed a commit that referenced this pull request Nov 3, 2022
…#2770)

* Change classname prefix wiz to vb (#2581)

Signed-off-by: abbyhu2000 <[email protected]>

Signed-off-by: abbyhu2000 <[email protected]>

* Change wizard to vis_builder in file names and paths (#2587)

Change all wizard reference in file names and paths to vis_builder

Signed-off-by: abbyhu2000 <[email protected]>

Signed-off-by: abbyhu2000 <[email protected]>

* Rename wizard to visBuilder in class name, type name and function name (#2639)

Rname wizard to visBuilder

Signed-off-by: abbyhu2000 <[email protected]>

Signed-off-by: abbyhu2000 <[email protected]>

* [Vis Builder] Rename wizard on save modal and visualization table (#2645)

* Rename wizard on save modal and visualization table

Change the wizard reference in save modal title, toggle and visualization table

Signed-off-by: abbyhu2000 <[email protected]>

* Save visualization on save modal, VisBuilder for chart type

Signed-off-by: abbyhu2000 <[email protected]>

* No experimental flag

Signed-off-by: abbyhu2000 <[email protected]>

Signed-off-by: abbyhu2000 <[email protected]>

* Change save object type, wizard id and name to visBuilder (#2673)

* Change save object type, wizard ID and Name to visBuilder

Signed-off-by: abbyhu2000 <[email protected]>

* Rename wizard in functional tests

Signed-off-by: abbyhu2000 <[email protected]>

* Finalize plugin-id and plugin-name and saved-object-type

Signed-off-by: abbyhu2000 <[email protected]>

* Change official name to VisBuilder

Signed-off-by: abbyhu2000 <[email protected]>

* Delete migration

Signed-off-by: abbyhu2000 <[email protected]>

* Fix functional test

Signed-off-by: abbyhu2000 <[email protected]>

* Update snapshot

Signed-off-by: abbyhu2000 <[email protected]>

Signed-off-by: abbyhu2000 <[email protected]>

Signed-off-by: abbyhu2000 <[email protected]>
sipopo pushed a commit to sipopo/OpenSearch-Dashboards that referenced this pull request Dec 16, 2022
opensearch-project#2639)

Rname wizard to visBuilder

Signed-off-by: abbyhu2000 <[email protected]>

Signed-off-by: abbyhu2000 <[email protected]>
Signed-off-by: Sergey V. Osipov <[email protected]>
Arpit-Bandejiya pushed a commit to Arpit-Bandejiya/OpenSearch-Dashboards that referenced this pull request Jan 13, 2023
opensearch-project#2639)

Rname wizard to visBuilder

Signed-off-by: abbyhu2000 <[email protected]>

Signed-off-by: abbyhu2000 <[email protected]>
Signed-off-by: Arpit Bandejiya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x rename v2.4.0 'Issues and PRs related to version v2.4.0' vis builder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants