[Vis Builder] Update vislib params and misc fixes

[ashwin-pc]

Description

This PR consists of 2 main changes

• Fixes for issues identified from Functional tests (commit: 563342)
• Adds additional aggregation parameters for Vislib charts (Bar, Line and Area) (Commit: d96669)

Issues Resolved

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
  • yarn test:ftr
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[codecov-commenter]

Codecov Report

Merging #2610 (563342b) into main (f29f734) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

❗ Current head 563342b differs from pull request most recent head f92ec36. Consider uploading reports for the commit f92ec36 to get more accurate results

@@            Coverage Diff             @@
##             main    #2610      +/-   ##
==========================================
- Coverage   66.81%   66.80%   -0.02%     
==========================================
  Files        3207     3207              
  Lines       61136    61137       +1     
  Branches     9313     9313              
==========================================
- Hits        40851    40845       -6     
- Misses      18055    18060       +5     
- Partials     2230     2232       +2     

Impacted Files	Coverage Δ
...ilder/public/embeddable/disabled_visualization.tsx	0.00% <ø> (ø)
...ilder/public/embeddable/vis_builder_embeddable.tsx	0.99% <0.00%> (-0.01%)	⬇️
...blic/embeddable/vis_builder_embeddable_factory.tsx	11.11% <ø> (ø)
...public/visualizations/vislib/area/area_vis_type.ts	100.00% <ø> (ø)
...ualizations/vislib/histogram/histogram_vis_type.ts	100.00% <ø> (ø)
...public/visualizations/vislib/line/line_vis_type.ts	100.00% <ø> (ø)
...s/osd-optimizer/src/node/node_auto_tranpilation.ts	83.67% <0.00%> (-4.09%)	⬇️
packages/osd-optimizer/src/node/cache.ts	50.00% <0.00%> (-2.78%)	⬇️
...ic/application/models/sense_editor/sense_editor.ts	64.00% <0.00%> (-0.89%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[joshuarrrr]

Looks good.

1. Why did we need to add uiState to the embeddable?
2. For the future, we should consider consolidating common UI schemas (line, area, histogram and other XY-type charts share a bunch of properties that we can dedupe and inherit)

[joshuarrrr]

nice, I was going to ask you about this.

[ashwin-pc]

Yep, was called out in user testing :)

[joshuarrrr]

this seems a little weird... maybe a comment would help explain?

[ashwin-pc]

This is because depending on the type of visualization (using the 'visualization' saved object or 'visBuilder' visualization) the location of the experimental property changes. I'd add a comment but honestly why they are in two different locations is beyond me so a comment would essentially describe this as you see it in the code. We dont have other aliased visualization to know for sure if its specific to aliased visualizations or just VisBuilder

[ashwin-pc]

Why did we need to add uiState to the embeddable?

Vislib visualization expect the UIState object to persist even when the parameters for the visualization change. We dont use the UIState in the visualization yet so i'm just passing in an empty UIState for now. Without this, updating the query in the Dashboard will cause VisLib visualizations to error out.

For the future, we should consider consolidating common UI schemas (line, area, histogram and other XY-type charts share a bunch of properties that we can dedupe and inherit)

Agreed. I didnt do that here because of the upcoming transition away from VisLib. This view keeps understanding each vis types properties a lot easier. Can go either way, but this way its easier to reason them when we refactor.