Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support rendering castellated holes correctly #325

Open
cdwilson opened this issue Sep 12, 2022 · 1 comment
Open

Support rendering castellated holes correctly #325

cdwilson opened this issue Sep 12, 2022 · 1 comment
Labels
wishlist Good to have features

Comments

@cdwilson
Copy link

Feature request to render castellated holes (plated half-holes) correctly. In KiCad, plated holes which intersect the board outline are assumed to be castellated holes and are rendered correctly. The interactive BOM doesn't currently render these correctly.

image

image

@qu1ck
Copy link
Member

qu1ck commented Sep 12, 2022

This is a good feature but unfortunately not easy to implement.

Note to my future self or anyone who would want to work on this. One way to tackle it would be to rebuild the outline path from the edge cuts segments (i.e. stitch together the line segments, arcs, circles, etc) and use that path as a clipping region for the background layer. Care of the even-odd rule or outline winding direction should be taken to correctly process inner holes.
This will cut the castellated hole in half and will make it clear that it's castellated.
Additionally pad drill holes that are intersected by edge cuts could be rendered in background color instead of the grey to make them seamless.

Another way is to patch kicad to have the same logic I outlined above be exposed in api or to have the build outline stored in the pcb data. Less geometry related coding in ibom, more kicad source work. Also won't work for other supported formats.

@qu1ck qu1ck added the wishlist Good to have features label Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wishlist Good to have features
Projects
None yet
Development

No branches or pull requests

2 participants