Unwrap else after return in preceding if

[timtebeek]

Added a new recipe, polished it up, and ran it on this repository to flush out any potential issues. Seemed straightforward enough and nicely reduces needless indentation. Let me know if you agree and then we can run this more broadly, and enforce it going forward.

[timtebeek]

This is the actual recipe that needs review.

[greg-at-moderne]

Another test case I'd add is with nested ifs in the primary branch. Something like:

if (someCondition) {
  // default logic
  if (somethingRare) {
     return "terminate all processing";
  }
} else {
  // non-standard logic
}

IMHO no changes should be made here.

[greg-at-moderne]

Would be interesting to add a test case where only some of the ifs have the return here. Like only the two branch. That's similar to ifWithoutReturnNotChanged test case, but with chaining.

[greg-at-moderne]

Also, not sure if it should go into the same recipe, or a separate one. The same kind of analysis and changes could be made with throw statements.

if (creditCardNumber.length() < 16) {
   throw new IllegalArgumentException("No shopping for you");
} else {
   // here comes the real logic which could be unwrapped
}