feature: resty.limit.count does not increment when rejected

Author: mikz

lib/resty/limit/count.lua

@@ -54,6 +54,9 @@ function _M.incoming(self, key, commit)
     end
 
     if count > limit then
+        if commit then
+           self:uncommit(key)
+        end
         return nil, "rejected"
     end
 

t/count.t

@@ -276,3 +276,50 @@ remaining: 8
 --- no_error_log
 [error]
 [lua]
+
+
+
+=== TEST 7: over incrementing when over limit
+--- http_config eval: $::HttpConfig
+--- config
+    location = /t {
+        content_by_lua_block {
+            local limit_count = require "resty.limit.count"
+            local lim = limit_count.new("store", 1, 10)
+            ngx.shared.store:flush_all()
+            local key = "foo"
+
+            local delay, err = lim:incoming(key, true)
+            if not delay then
+                ngx.say("failed to limit count: ", err)
+            else
+                local remaining = err
+                ngx.say("remaining: ", remaining)
+            end
+
+            local delay, err = lim:incoming(key, true)
+            if not delay then
+                ngx.say("failed to limit count: ", err)
+            else
+                local remaining = err
+                ngx.say("remaining: ", remaining)
+            end
+
+            local remaining, err = lim:uncommit(key)
+
+            if not remaining then
+                ngx.say("failed to uncommit count: ", err)
+            else
+                ngx.say("remaining: ", remaining)
+            end
+        }
+    }
+--- request
+    GET /t
+--- response_body
+remaining: 0
+failed to limit count: rejected
+remaining: 1
+--- no_error_log
+[error]
+[lua]