Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor validations #78

Closed
2 tasks
jpmckinney opened this issue Apr 24, 2014 · 1 comment
Closed
2 tasks

Refactor validations #78

jpmckinney opened this issue Apr 24, 2014 · 1 comment

Comments

@jpmckinney
Copy link
Member

  • Mix represent-canada-quality into the Pupa import step so that errors come up earlier in process, using BaseImporter#postimport
  • Rewrite scrapers-ca patch.py with plain Python by overriding the validate method, or implementing the pre_save method
@jpmckinney jpmckinney added the code label May 8, 2014
@jpmckinney jpmckinney changed the title Refactoring Refactor validations May 12, 2014
@jpmckinney jpmckinney mentioned this issue May 14, 2014
Closed
@jpmckinney
Copy link
Member Author

Rewriting patch.py with plain Python would make it harder to stay in sync with whatever validations exist in Pupa already.

Resolving opencivicdata/pupa#81 would make it easier to catch errors during scraper development, but postponing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jpmckinney