test: add e2e test cases for external transitive deps

pieh · pieh · commit 7d85c9457031 · 2025-11-28T18:24:56.000+01:00
diff --git a/tests/e2e/turborepo.test.ts b/tests/e2e/turborepo.test.ts
@@ -107,6 +107,15 @@ test.describe('[PNPM] Package manager', () => {
     const date3 = await page.getByTestId('date-now').textContent()
     expect(date3).not.toBe(date2)
   })
+
+  test('transitive external dependencies are supported', async ({ page, turborepo }) => {
+    const pageResponse = await page.goto(new URL('/transitive-external-deps', turborepo.url).href)
+
+    expect(pageResponse?.status()).toBe(200)
+
+    await expect(page.getByTestId('dep-a-version')).toHaveText('3.10.1')
+    await expect(page.getByTestId('dep-b-version')).toHaveText('4.17.21')
+  })
 })
 
 test.describe('[NPM] Package manager', () => {
@@ -228,4 +237,15 @@ test.describe('[NPM] Package manager', () => {
       '.env.production.local': 'defined in .env.production.local',
     })
   })
+
+  test('transitive external dependencies are supported', async ({ page, turborepoNPM }) => {
+    const pageResponse = await page.goto(
+      new URL('/transitive-external-deps', turborepoNPM.url).href,
+    )
+
+    expect(pageResponse?.status()).toBe(200)
+
+    await expect(page.getByTestId('dep-a-version')).toHaveText('3.10.1')
+    await expect(page.getByTestId('dep-b-version')).toHaveText('4.17.21')
+  })
 })
diff --git a/tests/fixtures/turborepo-npm/apps/page-router/next.config.js b/tests/fixtures/turborepo-npm/apps/page-router/next.config.js
@@ -8,6 +8,7 @@ const nextConfig = {
   },
   transpilePackages: ['@repo/ui'],
   outputFileTracingRoot: join(__dirname, '..', '..'),
+  serverExternalPackages: ['lodash'],
 }
 
 module.exports = nextConfig
diff --git a/tests/fixtures/turborepo-npm/apps/page-router/package.json b/tests/fixtures/turborepo-npm/apps/page-router/package.json
@@ -8,6 +8,8 @@
   },
   "dependencies": {
     "@netlify/functions": "^2.7.0",
+    "@repo/dep-a": "*",
+    "@repo/dep-b": "*",
     "@repo/ui": "*",
     "next": "latest",
     "react": "^18.2.0",
diff --git a/tests/fixtures/turborepo-npm/apps/page-router/pages/transitive-external-deps.js b/tests/fixtures/turborepo-npm/apps/page-router/pages/transitive-external-deps.js
@@ -0,0 +1,26 @@
+import depA from '@repo/dep-a'
+import depB from '@repo/dep-b'
+
+export default function TransitiveDeps() {
+  return (
+    <body>
+      <ul>
+        <li>
+          dep-a uses lodash version 3.10.1 and we should see this version here:{' '}
+          <span data-testId="dep-a-version">{depA}</span>
+        </li>
+        <li>
+          dep-b uses lodash version 4.17.21 and we should see this version here:{' '}
+          <span data-testId="dep-b-version">{depB}</span>
+        </li>
+      </ul>
+    </body>
+  )
+}
+
+// just to ensure this is rendered in runtime and not prerendered
+export async function getServerSideProps() {
+  return {
+    props: {},
+  }
+}
diff --git a/tests/fixtures/turborepo-npm/packages/dep-a/index.js b/tests/fixtures/turborepo-npm/packages/dep-a/index.js
@@ -0,0 +1,3 @@
+import lodash from 'lodash'
+
+export default lodash.VERSION
diff --git a/tests/fixtures/turborepo-npm/packages/dep-a/package.json b/tests/fixtures/turborepo-npm/packages/dep-a/package.json
@@ -0,0 +1,7 @@
+{
+  "name": "@repo/dep-a",
+  "version": "1.0.0",
+  "dependencies": {
+    "lodash": "3.10.1"
+  }
+}
diff --git a/tests/fixtures/turborepo-npm/packages/dep-b/index.js b/tests/fixtures/turborepo-npm/packages/dep-b/index.js
@@ -0,0 +1,3 @@
+import lodash from 'lodash'
+
+export default lodash.VERSION
diff --git a/tests/fixtures/turborepo-npm/packages/dep-b/package.json b/tests/fixtures/turborepo-npm/packages/dep-b/package.json
@@ -0,0 +1,7 @@
+{
+  "name": "@repo/dep-b",
+  "version": "1.0.0",
+  "dependencies": {
+    "lodash": "4.17.21"
+  }
+}
diff --git a/tests/fixtures/turborepo/apps/page-router/next.config.js b/tests/fixtures/turborepo/apps/page-router/next.config.js
@@ -8,6 +8,7 @@ const nextConfig = {
   },
   transpilePackages: ['@repo/ui'],
   outputFileTracingRoot: join(__dirname, '..', '..'),
+  serverExternalPackages: ['lodash'],
 }
 
 module.exports = nextConfig
diff --git a/tests/fixtures/turborepo/apps/page-router/package.json b/tests/fixtures/turborepo/apps/page-router/package.json
@@ -8,6 +8,8 @@
   },
   "dependencies": {
     "@netlify/functions": "^2.7.0",
+    "@repo/dep-a": "workspace:*",
+    "@repo/dep-b": "workspace:*",
     "@repo/ui": "workspace:*",
     "next": "latest",
     "react": "^18.2.0",
diff --git a/tests/fixtures/turborepo/apps/page-router/src/pages/transitive-external-deps.js b/tests/fixtures/turborepo/apps/page-router/src/pages/transitive-external-deps.js
@@ -0,0 +1,26 @@
+import depA from '@repo/dep-a'
+import depB from '@repo/dep-b'
+
+export default function TransitiveDeps() {
+  return (
+    <body>
+      <ul>
+        <li>
+          dep-a uses lodash version 3.10.1 and we should see this version here:{' '}
+          <span data-testId="dep-a-version">{depA}</span>
+        </li>
+        <li>
+          dep-b uses lodash version 4.17.21 and we should see this version here:{' '}
+          <span data-testId="dep-b-version">{depB}</span>
+        </li>
+      </ul>
+    </body>
+  )
+}
+
+// just to ensure this is rendered in runtime and not prerendered
+export async function getServerSideProps() {
+  return {
+    props: {},
+  }
+}
diff --git a/tests/fixtures/turborepo/packages/dep-a/index.js b/tests/fixtures/turborepo/packages/dep-a/index.js
@@ -0,0 +1,3 @@
+import lodash from 'lodash'
+
+export default lodash.VERSION
diff --git a/tests/fixtures/turborepo/packages/dep-a/package.json b/tests/fixtures/turborepo/packages/dep-a/package.json
@@ -0,0 +1,7 @@
+{
+  "name": "@repo/dep-a",
+  "version": "1.0.0",
+  "dependencies": {
+    "lodash": "3.10.1"
+  }
+}
diff --git a/tests/fixtures/turborepo/packages/dep-b/index.js b/tests/fixtures/turborepo/packages/dep-b/index.js
@@ -0,0 +1,3 @@
+import lodash from 'lodash'
+
+export default lodash.VERSION
diff --git a/tests/fixtures/turborepo/packages/dep-b/package.json b/tests/fixtures/turborepo/packages/dep-b/package.json
@@ -0,0 +1,7 @@
+{
+  "name": "@repo/dep-b",
+  "version": "1.0.0",
+  "dependencies": {
+    "lodash": "4.17.21"
+  }
+}

Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,7 @@ const nextConfig = {`
`8`	`8`	`},`
`9`	`9`	`transpilePackages: ['@repo/ui'],`
`10`	`10`	`outputFileTracingRoot: join(__dirname, '..', '..'),`
	`11`	`+ serverExternalPackages: ['lodash'],`
`11`	`12`	`}`
`12`	`13`
`13`	`14`	`module.exports = nextConfig`
Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,3 @@`
	`1`	`+import lodash from 'lodash'`
	`2`	`+`
	`3`	`+export default lodash.VERSION`