Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange the Policy API's speed limit example #482

Merged
merged 1 commit into from
Jun 26, 2020

Conversation

jrheard
Copy link
Contributor

@jrheard jrheard commented Apr 17, 2020

Rearrange the Policy API's speed-limit examples from most specific to least specific, per the API's "order of operations" system.

Explain pull request

Right now, these two examples are in (least specific, most specific) order, which should mean that the "Venice Beach on weekend afternoons" Rule never applies to any vehicle, which seems like probably a mistake!

Is this a breaking change

  • No, not breaking

Impacted Spec

Which spec(s) will this pull request impact?

  • policy

Rearrange the Policy API's speed-limit examples from most specific to least specific, per the API's "order of operations" system.
@jrheard jrheard requested a review from a team April 17, 2020 22:23
@jrheard jrheard requested a review from a team as a code owner April 17, 2020 22:23
@jrheard jrheard changed the title Rearrange the speed limit Policy example Rearrange the Policy API's speed limit example Apr 17, 2020
@Retzoh
Copy link
Contributor

Retzoh commented Apr 30, 2020

@Karcass can you take a look at it and see if we should include wording clarifications to the order of operation spec?

@schnuerle schnuerle added this to the 1.0.0 milestone Jun 10, 2020
@marie-x marie-x self-requested a review June 26, 2020 20:30
Copy link
Collaborator

@marie-x marie-x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schnuerle schnuerle merged commit c82637c into openmobilityfoundation:dev Jun 26, 2020
@jrheard jrheard deleted the patch-1 branch June 26, 2020 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants