Yarn and Typescript fixes #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Jpoliachik
commented
May 12, 2022
Jpoliachik
commented
- Setup Yarn 3.2 (needed for yarn patch, and generally better optimized builds)
- Patch Jest-Dom types to fix Typescript conflicts with Vitest TS error when using vitest globals and @testing-library/jest-dom testing-library/jest-dom#427
- Pin React to specific version and add resolution to resolve conflicting types
- Remove empty .css.ts file which was throwing TS errors
✅ Deploy Preview for studio-design-system ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jose-elias-alvarez
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.