Skip to content

Commit 1cfbf25

Browse files
authored
refactor: disable Sarama metric collection (#2007)
1 parent 6ed4dab commit 1cfbf25

File tree

1 file changed

+14
-11
lines changed

1 file changed

+14
-11
lines changed

openmeter/watermill/driver/kafka/broker.go

+14-11
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@ import (
88
"time"
99

1010
"github.com/IBM/sarama"
11+
gometrics "github.com/rcrowley/go-metrics"
1112
otelmetric "go.opentelemetry.io/otel/metric"
1213

1314
"github.com/openmeterio/openmeter/app/config"
14-
"github.com/openmeterio/openmeter/openmeter/watermill/driver/kafka/metrics"
1515
)
1616

1717
const (
@@ -91,16 +91,19 @@ func (o *BrokerOptions) createKafkaConfig(role string) (*sarama.Config, error) {
9191
config.Producer.Retry.Max = 10
9292
config.Producer.Return.Successes = true
9393

94-
meterRegistry, err := metrics.NewRegistry(metrics.NewRegistryOptions{
95-
MetricMeter: o.MetricMeter,
96-
NameTransformFn: SaramaMetricRenamer(role),
97-
ErrorHandler: metrics.LoggingErrorHandler(o.Logger),
98-
})
99-
if err != nil {
100-
return nil, err
101-
}
102-
103-
config.MetricRegistry = meterRegistry
94+
//meterRegistry, err := metrics.NewRegistry(metrics.NewRegistryOptions{
95+
// MetricMeter: o.MetricMeter,
96+
// NameTransformFn: SaramaMetricRenamer(role),
97+
// ErrorHandler: metrics.LoggingErrorHandler(o.Logger),
98+
//})
99+
//if err != nil {
100+
// return nil, err
101+
//}
102+
//
103+
//config.MetricRegistry = meterRegistry
104+
105+
// FIXME(chrisgacsal): disable metric collection to test possibler mem/goroutine leak
106+
gometrics.UseNilMetrics = true
104107

105108
return config, nil
106109
}

0 commit comments

Comments
 (0)