Fix requeue bug

Author: moelsayed

internal/controller/federatedmanagedmetric_controller.go

@@ -89,7 +89,6 @@ func (r *FederatedManagedMetricReconciler) scheduleNextReconciliation(metric *v1
 
 	elapsed := time.Since(metric.Status.LastReconcileTime.Time)
 	return ctrl.Result{
-		Requeue:      true,
 		RequeueAfter: metric.Spec.Interval.Duration - elapsed,
 	}, nil
 }
@@ -241,7 +240,6 @@ func (r *FederatedManagedMetricReconciler) Reconcile(ctx context.Context, req ct
 	l.Info(fmt.Sprintf("federated managed metric '%s' re-queued for execution in %v\n", metric.Spec.Name, requeueTime))
 
 	return ctrl.Result{
-		Requeue:      true,
 		RequeueAfter: requeueTime,
 	}, nil
 }

internal/controller/federatedmetric_controller.go

@@ -90,7 +90,6 @@ func scheduleNextReconciliation(metric *v1alpha1.FederatedMetric) (ctrl.Result,
 
 	elapsed := time.Since(metric.Status.LastReconcileTime.Time)
 	return ctrl.Result{
-		Requeue:      true,
 		RequeueAfter: metric.Spec.Interval.Duration - elapsed,
 	}, nil
 }
@@ -243,7 +242,6 @@ func (r *FederatedMetricReconciler) Reconcile(ctx context.Context, req ctrl.Requ
 	l.Info(fmt.Sprintf("federated metric '%s' re-queued for execution in %v\n", metric.Spec.Name, requeueTime))
 
 	return ctrl.Result{
-		Requeue:      true,
 		RequeueAfter: requeueTime,
 	}, nil
 }

internal/controller/managedmetric_controller.go

@@ -64,7 +64,6 @@ func (r *ManagedMetricReconciler) getRestConfig() *rest.Config {
 func (r *ManagedMetricReconciler) scheduleNextReconciliation(metric *v1alpha1.ManagedMetric) (ctrl.Result, error) {
 	elapsed := time.Since(metric.Status.Observation.Timestamp.Time)
 	return ctrl.Result{
-		Requeue:      true,
 		RequeueAfter: metric.Spec.Interval.Duration - elapsed,
 	}, nil
 }
@@ -262,7 +261,6 @@ func (r *ManagedMetricReconciler) Reconcile(ctx context.Context, req ctrl.Reques
 	l.Info(fmt.Sprintf("managed metric '%s' re-queued for execution in %v\n", metric.Spec.Name, requeueTime))
 
 	return ctrl.Result{
-		Requeue:      true,
 		RequeueAfter: requeueTime,
 	}, nil
 }

internal/controller/metric_controller.go

@@ -85,7 +85,6 @@ func (r *MetricReconciler) scheduleNextReconciliation(metric *v1alpha1.Metric) (
 
 	elapsed := time.Since(metric.Status.Observation.Timestamp.Time)
 	return ctrl.Result{
-		Requeue:      true,
 		RequeueAfter: metric.Spec.Interval.Duration - elapsed,
 	}, nil
 }
@@ -267,7 +266,6 @@ func (r *MetricReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctr
 	l.Info(fmt.Sprintf("metric '%s' re-queued for execution in %v\n", metric.Spec.Name, requeueTime))
 
 	return ctrl.Result{
-		Requeue:      true,
 		RequeueAfter: requeueTime,
 	}, nil
 }

internal/controller/metric_controller_test.go

@@ -123,7 +123,6 @@ func (r *TestMetricReconciler) Reconcile(ctx context.Context, req ctrl.Request)
 
 	// Requeue
 	return ctrl.Result{
-		Requeue:      true,
 		RequeueAfter: metric.Spec.Interval.Duration,
 	}, nil
 }