Handle reflex angles in CylinderSector #3303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems a lot better indeed, it works great. Thanks for taking a look! |
JoffreyDorville
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
Thanks @paulromano for this PR and thanks @nplinden for pointing out this issue and helping in finding a solution!
I also encountered this limitation some time ago while developing a generic control drum builder for a model. I am glad that I will be able to use the corrected CylinderSector to simplify my own code!
Also, the inversion of the planes normal is definitely an elegant solution to the x-axis inversion occurring during the change of frames. I really like this one!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #3293 and is an alternative solution to that proposed in #3296. First, thanks @nplinden for identifying the issue and proposing a solution. As I was looking over your PR, I realized there was a simpler solution, which is to simply use a
|operator instead of&between the planar halfspaces if the angle is greater than 180°. I made a few other improvements in the implementation while I was at it:__pos__, which is no longer needed for composite surfaces (the default inherited fromCompositeSurfaceworks fine)__neg__@nplinden Please give this a try and let me know if it works for you.
Checklist
I have run clang-format (version 15) on any C++ source files (if applicable)