Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

big_omega implementation disagrees with published formula #5

Open
translunar opened this issue Jan 24, 2020 · 0 comments
Open

big_omega implementation disagrees with published formula #5

translunar opened this issue Jan 24, 2020 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@translunar
Copy link
Collaborator

I haven't actually been able to get it to produce an incorrect result, but neither can I find my derivation of it. I don't want to fix something that isn't broken.

The version from Valenti 2015 is here (but note that it is missing a one-half in Eq. 39):
Valenti 2015 equations 38-41

From Markley 2003, it's as follows:
Markley 2003 equations 8-10

Note also that Markley gives the quaternion in qx qy qz qw order, whereas Valenti is qw qx qy qz (like pyquat).

Unit test code is attached showing same results whether Valenti is used or the existing version.

I've opened this issue so other people know it's of some concern. If anyone can show an example of it misbehaving, that would be outstanding.

Traces from: https://github.com/autumnsault/pyquat/issues/9

@translunar translunar added the help wanted Extra attention is needed label Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant