Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Root user needed for some operations #1970

Closed
1 task done
jzakotnik opened this issue Sep 11, 2024 · 2 comments
Closed
1 task done

Root user needed for some operations #1970

jzakotnik opened this issue Sep 11, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@jzakotnik
Copy link
Contributor

  • I have searched the issues of this repository and believe that this is not a duplicate.

In a couple of services, there's the check for a explicit root user, via userId === "root". Is this correct? I would have expected that the root user is disabled and the services are used via respective authenticated users in their role.

@jzakotnik jzakotnik added the bug Something isn't working label Sep 11, 2024
@SamuelPull
Copy link
Collaborator

@jzakotnik If it is correct depends on a criterion I suppose.
In the email service, root can create, read, update, and delete email addresses. On the other hand, frontend doesn't expose a way for root user to read or modify these. I think it reflects conflicting design decisions, and as you wrote, root access in the email service to user's addresses should be disabled.
Provisioning and migration are necessary.
Frontend uses the check to i.a. limit the actions root can do (root can't create projects).

@jzakotnik
Copy link
Contributor Author

I agree, let's close this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants