Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Management of corrections #1399

Closed
2 tasks done
LukasKM opened this issue Jun 15, 2023 · 3 comments
Closed
2 tasks done

Management of corrections #1399

LukasKM opened this issue Jun 15, 2023 · 3 comments
Assignees
Labels
feature Indicates a new feature implementation frontend Indicates frontend related issue or feature

Comments

@LukasKM
Copy link

LukasKM commented Jun 15, 2023

  • The feature was discussed in discussions of this repository.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Management of Corrections💡

I would like to propose a feature to improve management of corrections, which would allow to mark workflow items that need to be corrected, and then through a toggle button in the UI, display or hide the corrected steps. The end user would then have the possibility to see the final or "clean" process, or has the view of all detailed steps including those that were corrected.

The implementation could be as follows

  1. Introduce a label "correction" (or similar) that can be applied to a workflow item
  2. Add a toggle button in the frontend to display or hide corrections
  3. Add a specific permission to "mark as correction" that can be given to the users - this would add a level of control to the feature.
@LukasKM LukasKM added the feature Indicates a new feature implementation label Jun 15, 2023
@issuelabeler issuelabeler bot added the frontend Indicates frontend related issue or feature label Jun 15, 2023
@georgimld georgimld added this to the Trubudget 2.3.0 milestone Jul 3, 2023
@SamuelPull SamuelPull self-assigned this Jul 3, 2023
@SamuelPull
Copy link
Collaborator

SamuelPull commented Jul 3, 2023

Toggle button to display and hide corrections and implementation of its functionality can be done in a separate pull request. Displaying or collapsing corrections should be purely presentational functionality.

List of required changes: (subject to change)

  • New action button visible to users that have right to correct wf items
  • Clicking "correct" button opens a Correction dialog similar to Edit workflow item
  • Submitting correction should leave original wf item unchanged. Instead, new correctional WF item is created, linked to the corrigendum by its ID. (Who should be the assignee?)
    Numerical changes can be calculated from differences between an original and a correction, and these should be written in a new workflow item.
  • reducer actions + reducers
  • translation keys
  • E2E tests

If only select users have the right to issue corrections, additionally:

  • correction API endpoint (/api/workflowitem.correct) ?
  • correction permissions
  • E2E tests
  • Update provisioning data

@SamuelPull
Copy link
Collaborator

For now, simple solution of enabling input of negative values (#1407) in workflow is implemented.

@georgimld
Copy link
Collaborator

Closed by #1407

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Indicates a new feature implementation frontend Indicates frontend related issue or feature
Projects
None yet
Development

No branches or pull requests

3 participants