Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove peer deps in frontend #1166

Closed
2 tasks done
daniel-arnauer opened this issue May 31, 2022 · 2 comments
Closed
2 tasks done

Remove peer deps in frontend #1166

daniel-arnauer opened this issue May 31, 2022 · 2 comments
Labels
bug Something isn't working frontend Indicates frontend related issue or feature

Comments

@daniel-arnauer
Copy link
Contributor

daniel-arnauer commented May 31, 2022

Description 😯

@mui/[email protected] and connected-react-router are not compatible with React 18:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: @mui/[email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR! react@"^18.0.0" from the root project
npm ERR! peer react@">=16.8.0" from @emotion/[email protected]
npm ERR! node_modules/@emotion/react
npm ERR! @emotion/react@"^11.8.2" from the root project
npm ERR! peer @emotion/react@"^11.0.0-rc.0" from @emotion/[email protected]
npm ERR! node_modules/@emotion/styled
npm ERR! @emotion/styled@"^11.8.1" from the root project
npm ERR! 3 more (@mui/material, @mui/styled-engine, @mui/system)
npm ERR! 3 more (@mui/material, @mui/styled-engine, @mui/system)
npm ERR! 22 more (@emotion/styled, @mui/base, @mui/icons-material, ...)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^17.0.0" from @mui/[email protected]
npm ERR! node_modules/@mui/styles
npm ERR! @mui/styles@"^5.5.3" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: [email protected]
npm ERR! node_modules/react
npm ERR! peer react@"^17.0.0" from @mui/[email protected]
npm ERR! node_modules/@mui/styles
npm ERR! @mui/styles@"^5.5.3" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

How to reproduce 🕹

Run npm install in frontend

Solution

  • wait for updates in connected-react-router
  • remove @mui/styles

Done in subtask #1352

@daniel-arnauer daniel-arnauer added the bug Something isn't working label May 31, 2022
@daniel-arnauer daniel-arnauer added this to the Trubudget 2.1.0 milestone May 31, 2022
@issuelabeler issuelabeler bot added the frontend Indicates frontend related issue or feature label May 31, 2022
@daniel-arnauer daniel-arnauer self-assigned this Jun 20, 2022
@SamuelPull
Copy link
Collaborator

connected-react-router will most probably not be updated supasate/connected-react-router#613

@SamuelPull
Copy link
Collaborator

Closing, as most of frontend libraries are up to date, and --legacy-peer-deps is no longer needed.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend Indicates frontend related issue or feature
Projects
None yet
Development

No branches or pull requests

3 participants