Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bc: Delete md5 hashing from restore SP 0.5 #1072

Closed
Stezido opened this issue Mar 24, 2022 Discussed in #870 · 1 comment
Closed

bc: Delete md5 hashing from restore SP 0.5 #1072

Stezido opened this issue Mar 24, 2022 Discussed in #870 · 1 comment
Assignees
Labels
blockchain Indicates blockchain related issue or feature breaking change Indicates this will require a breaking change idea: accepted Indicates an idea in Discussions has been accepted

Comments

@Stezido
Copy link
Contributor

Stezido commented Mar 24, 2022

Discussed in #870

Originally posted by georgimld December 16, 2020

Summary 💡

When creating a backup, a hashing is now calculated with a sha256 hash. It used to be created with md5, but as mentioned in #513 it wasn't working perfectly. Restoring a backup is now possible with both the old version (md5 hash) and the new (sha256), as implemented in #693 .
Deleting the md5 hash function would not allow old backups to be restored anymore, this would be a breaking change and should only be implemented in Trubudget 2.0.0.

@Stezido Stezido added blockchain Indicates blockchain related issue or feature idea: accepted Indicates an idea in Discussions has been accepted breaking change Indicates this will require a breaking change labels Mar 24, 2022
@Stezido Stezido added this to the TruBudget 2.0.0 milestone Mar 24, 2022
@mayrmartin mayrmartin self-assigned this Apr 6, 2022
@Stezido Stezido changed the title bc: Delete md5 hashing from restore bc: Delete md5 hashing from restore SP 0.5 May 9, 2022
@Stezido
Copy link
Contributor Author

Stezido commented May 9, 2022

TODOs:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blockchain Indicates blockchain related issue or feature breaking change Indicates this will require a breaking change idea: accepted Indicates an idea in Discussions has been accepted
Projects
None yet
Development

No branches or pull requests

2 participants