-
-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW]: BAMnostic: an OS-agnostic toolkit for genomic sequence analysis #826
Comments
Hello human, I'm @whedon. I'm here to help you with some common editorial tasks. @luizirber, it looks like you're currently assigned as the reviewer for this paper 🎉. ⭐ Important ⭐ If you haven't already, you should seriously consider unsubscribing from GitHub notifications for this (https://github.com/openjournals/joss-reviews) repository. As a reviewer, you're probably currently watching this repository which means for GitHub's default behaviour you will receive notifications (emails) for all reviews 😿 To fix this do the following two things:
For a list of things I can do to help you, just type:
|
|
@betteridiot we are starting review here. To expedite the review do you mind going through above list of check boxes and make sure they can be ticked (you can't tick them). Also check the PDF output carefully. Ping us here when you are done. |
Also address @peterjc concerns raised #779 (comment) here (I mean in this issue tracker): One thing on the text: "This is a significant limitation as no other Python implementation (besides pysam) can perform random access operation on BAM files." maybe insert the rider "published" or "released" as there are several, including my old Python code can do this but has not been formally published or released, https://github.com/JohnLonginotto/pybam ("A simple, 100% python, BAM file reader.") and some work at https://github.com/nijibabulu/pypysam/ As a potential user I would also want to know about plans for CRAM support (logged as betteridiot/bamnostic#4), CSI indexing (betteridiot/bamnostic#3), and BAM output (betteridiot/bamnostic#5). I know this is a lot to ask, and perhaps out of scope for JoSS, but as a user I would worry about the long term support as the SAM/BAM file format continues to evolve, (e.g. the overdue fix for long CIGAR strings last year, important with long reads - logged as betteridiot/bamnostic#6). In contrast, by building on top of the well supported HTSlib, pysam gets a lot of this maintenance work "for free", but a re-implementation would not (as I wrote earlier, this was a factor in me not formally releasing my own Python SAM/BAM code a years back). |
The PR: betteridiot/bamnostic#7 addresses the first issue raised by @peterjc. Also, a couple of these points were also addressed in my last comment in #779. I will reiterate it here though:
|
The points about CSI indexing and CRAM support were addressed similarly in betteridiot/bamnostic#3 and betteridiot/bamnostic#4 (respectively). |
Thanks, can you confirm you agree that all check boxes can be ticked by the reviewer(s)? |
I will have to explicitly add a section on Community guidelines for all items to be checked off. |
Current version is 0.8.7b2 Addressed @peterjc's comments on CRAM and CSI support is betteridiot/bamnostic#4 and betteridiot/bamnostic#3 (respectively) and added documentation about limitations in betteridiot/bamnostic@14747e7 CIGARs > 65535 support was added in betteridiot/bamnostic@6e55d64 |
At this point, I can confirm all items on the checklist can be checked off. The only point made by @peterjc that has yet to be addressed with increased functionality has been on BAM output. This is feature that will be added in the very near future and this issue can be found at betteridiot/bamnostic#5 |
Thanks. @luizirber over to you! |
BAM output betteridiot/bamnostic#5 was a feature request, quite a logical extension and one which will increase the utility of BAMnostic, but I did not mean to suggest it should delay or block this JOSS publication. |
Thank you @peterjc . I fully understood it as such. I was just being explicit with my intentions is all. |
Thanks @betteridiot. I think we are good to go. @luizirber would you be so kind to start reviewing this submission? @peterjc can help out if there are any issues. Thanks! |
on it |
@luizirber what is the latest update here? |
Hello @betteridiot! Great work on the software =] Some comments and two small things:
Checklist commentsGeneral checks
Documentation
Software paper
Fixes
|
betteridiot/bamnostic@fbd5e89f2296d78732e addresses the issues raises by @luizirber regarding the versions releases, the documentation error of The CONTRIBUTING.md file will take more time than these quick corrections. Regarding the comment about the automated tests: @luizirber , are you requesting more testing coverage is required before publication? Or, do the doctests fulfill the needs of the review at this point? |
Thanks for the quick answer! It is not required, I think it's already pretty good. Having 100% coverage is desirable but not that useful if you're writing tests just to hit the target, but I was a bit uncomfortable with only two tests. After I found the doctests this looked better, and I would suggest (but not require 😸) that you add a few more tests, but up to you. I checked the |
@peterjc how would you like the paper to cite PySAM? |
I know that according to APA citations style guides, when the DOI is not available for electronic resources, the reference should cite the URL (as done in paper.bib). Furthermore, the maintainers of PySAM requests that the original SAM/BAM format paper be cited in its stead (as done in paper.bib). This is also seen in pysam's Bioconda page, where the DOI points back to the SAM/BAM format paper again. |
OK, sounds fine to me. @luizirber when you think it is done we can start the publication process. |
betteridiot/bamnostic#13 adds a CONTRIBUTING.md and Contributor Covenant Code of Conduct to the project. The initial commit had some typos in the CONTRIBUTING.md file. These were addressed in betteridiot/bamnostic@6bbe4cd |
@pjotrp All box checked, ready to go! |
Cool. @arfon another publication to send into the ether! |
@whedon generate pdf |
|
@whedon set 10.5281/zenodo.1341915 as archive |
OK. 10.5281/zenodo.1341915 is the archive. |
@luizirber, @peterjc - many thanks for your reviews here and to @pjotrp for editing this submission ✨ @betteridiot - your paper is now accepted into JOSS and your DOI is https://doi.org/10.21105/joss.00826 ⚡ 🚀 💥 |
🎉🎉🎉 Congratulations on your paper acceptance! 🎉🎉🎉 If you would like to include a link to your paper from your README use the following code snippets:
This is how it will look in your documentation: We need your help! Journal of Open Source Software is a community-run journal and relies upon volunteer effort. If you'd like to support us please consider doing either one (or both) of the the following:
|
Thank you @pjotrp for keeping the review process moving. Thank you @peterjc and @luizirber for your insights. Lastly, thank you JoSS for this outlet. |
Agreed, this process was great and we will definitely consider publishing here again in the future! |
Submitting author: @betteridiot (Marcus)
Repository: https://github.com/betteridiot/bamnostic
Version: 0.8.4
Editor: @pjotrp
Reviewer: @luizirber, @peterjc
Archive: 10.5281/zenodo.1341915
Status
Status badge code:
Reviewers and authors:
Please avoid lengthy details of difficulties in the review thread. Instead, please create a new issue in the target repository and link to those issues (especially acceptance-blockers) in the review thread below. (For completists: if the target issue tracker is also on GitHub, linking the review thread in the issue or vice versa will create corresponding breadcrumb trails in the link target.)
Reviewer instructions & questions
@luizirber & @peterjc, please carry out your review in this issue by updating the checklist below. If you cannot edit the checklist please:
The reviewer guidelines are available here: https://joss.theoj.org/about#reviewer_guidelines. Any questions/concerns please let @pjotrp know.
✨ Please try and complete your review in the next two weeks ✨
Review checklist for @luizirber
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?Review checklist for @peterjc
Conflict of interest
Code of Conduct
General checks
Functionality
Documentation
Software paper
paper.md
file include a list of authors with their affiliations?The text was updated successfully, but these errors were encountered: